Page MenuHomePhabricator

[electrum] remove redundant parameters for command-line arguments
ClosedPublic

Authored by PiRK on Jun 28 2023, 16:30.

Details

Summary

The dest parameter is inferred from the first long option string, so no need to specify if when they are identical (--offline -> offline). See https://docs.python.org/3/library/argparse.html#dest

The store_true / store_false actions create default values False / True, so no need to specify the default argument when this is what we want.

This will avoid potential bugs wnd extra work when changing the command line arguments.

Test Plan

python -m electrumabc.tests.test_commands

Diff Detail

Repository
rABC Bitcoin ABC
Branch
test_update_checker
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24236
Build 48082: Build Diff
Build 48081: arc lint + arc unit