Differential D14183

[Apps][Examples] Remove chronik url input arg from getDetailsFromTxid
ClosedPublic
Actions

Authored by emack on Jul 1 2023, 08:42.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC70a4d39068f7: [Apps][Examples] Remove chronik url input arg from getDetailsFromTxid

Summary

As per feedback from D14166, removing the chronik url input arg

Test Plan

npm test
npm run getDetailsFromTxid <txid>

Diff Detail

Repository

rABC Bitcoin ABC

Branch

txDetails

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24292
Build 48194: Build Diff	app-dev-examples
Build 48193: arc lint + arc unit

Event Timeline

emack created this revision.Jul 1 2023, 08:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 1 2023, 08:42

emack requested review of this revision.Jul 1 2023, 08:42

Harbormaster completed remote builds in B24292: Diff 41157.Jul 1 2023, 08:43

bytesofman requested changes to this revision.Jul 1 2023, 21:14

bytesofman added inline comments.

apps/examples/scripts/getDetailsFromTxid.js
31	This URL is used by many scripts and should be exported by a config file

This revision now requires changes to proceed.Jul 1 2023, 21:14

emack requested review of this revision.Jul 1 2023, 22:57

emack added inline comments.

apps/examples/scripts/getDetailsFromTxid.js
31	As discussed

bytesofman accepted this revision.Jul 2 2023, 03:17

This revision is now accepted and ready to land.Jul 2 2023, 03:17

Closed by commit rABC70a4d39068f7: [Apps][Examples] Remove chronik url input arg from getDetailsFromTxid (authored by emack). · Explain WhyJul 2 2023, 03:33

This revision was automatically updated to reflect the committed changes.

emack added a commit: rABC70a4d39068f7: [Apps][Examples] Remove chronik url input arg from getDetailsFromTxid.

Revision Contents
Changeset List

Path

Size

apps/

examples/

README.md

6 lines

scripts/

getDetailsFromTxid.js

7 lines

Diff 41157

View Options

apps/examples/README.md