Page MenuHomePhabricator
Differential D14209

[ecash-herald] Prelim parsing for alias registration txs
ClosedPublic
Actions

Authored by bytesofman on Jul 4 2023, 14:43.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC629f7190d19f: [ecash-herald] Prelim parsing for alias registration txs
Summary

As we start testing alias registrations, we'd like these to not appear garbled.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
herald-alias-prelim-support
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24345
Build 48299: Build Diffecash-herald-tests
Build 48298: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jul 4 2023, 14:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 4 2023, 14:43
bytesofman requested review of this revision.Jul 4 2023, 14:43
bytesofman added a comment.Jul 4 2023, 14:44

image.png (101×231 px, 8 KB)

output from npm run sendMsgByBlock 799377

Harbormaster completed remote builds in B24340: Diff 41237.Jul 4 2023, 14:44
Fabien requested changes to this revision.Jul 4 2023, 16:22
Fabien added a subscriber: Fabien.
Fabien added inline comments.
apps/ecash-herald/src/parse.js
434 ↗(On Diff #41237)

Now I can crash your herald whenever I want with 0x6a042e78656305426F6F6D21 as a script for my tx.

This revision now requires changes to proceed.Jul 4 2023, 16:22
bytesofman updated this revision to Diff 41240.Jul 4 2023, 16:30

Add basic validation for alias registration txs

bytesofman updated this revision to Diff 41241.Jul 4 2023, 16:31

validate for alias tx version number

Harbormaster completed remote builds in B24343: Diff 41240.Jul 4 2023, 16:31
Harbormaster completed remote builds in B24344: Diff 41241.
bytesofman updated this revision to Diff 41242.Jul 4 2023, 16:32

unit test for invalid tx by invalid version

Harbormaster completed remote builds in B24345: Diff 41242.Jul 4 2023, 16:34
Fabien requested changes to this revision.Jul 4 2023, 16:36
Fabien added inline comments.
apps/ecash-herald/test/mocks/appTxSamples.js
444

You can also add a test for the case I crafted and have a stack of a single push

This revision now requires changes to proceed.Jul 4 2023, 16:36
bytesofman updated this revision to Diff 41247.Jul 4 2023, 17:05

test vector with empty stack after alias prefix

Harbormaster completed remote builds in B24349: Diff 41247.Jul 4 2023, 17:07
Fabien accepted this revision.Jul 4 2023, 18:16
This revision is now accepted and ready to land.Jul 4 2023, 18:16
Closed by commit rABC629f7190d19f: [ecash-herald] Prelim parsing for alias registration txs (authored by bytesofman). · Explain WhyJul 4 2023, 19:04
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC629f7190d19f: [ecash-herald] Prelim parsing for alias registration txs.

Revision Contents
Changeset List

PathSize
apps/
ecash-herald/
1 line
constants/
1 line
src/
24 lines
test/
mocks/
12 lines

Diff 41242

View Options

apps/ecash-herald/config.js

Loading...
View Options

apps/ecash-herald/constants/op_return.js

Loading...
View Options

apps/ecash-herald/src/parse.js

Loading...
View Options

apps/ecash-herald/test/mocks/appTxSamples.js

Loading...
View Options

apps/ecash-herald/test/parseTests.js

Loading...