Page MenuHomePhabricator

[alias-server] Deprecate isRegistered: true
ClosedPublic

Authored by bytesofman on Jul 11 2023, 17:23.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCcb1e964e7868: [alias-server] Deprecate isRegistered: true
Summary

If you have a blockheight and a txid, isRegistered: true is redundant.

Preserving isRegistered: false for aliases that are not registered. This is useful information, esp as you can only get it if you query a valid alias.

The meaning of a returned object with just {alias} is not intuitively understandable.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
alias-server-remove-flag
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24451
Build 48502: Build Diffalias-server-tests
Build 48501: arc lint + arc unit