[Cashtab] Move defaultCashtabCache out of Ticker.js
ClosedPublic
Actions

Authored by bytesofman on Aug 9 2023, 18:08.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC1e2863154acd: [Cashtab] Move defaultCashtabCache out of Ticker.js

Summary

T3261

Toward deprecating Ticker.js, move defaultCashtabCache to its own file

Note: "cashtabCache" and "cashtabSettings" are both somewhat of a mouthful. However, they reference specific objects. "settings" and "cache" are both general terms and we want to avoid ambiguity.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cache-out-ticker

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24717
Build 49026: Build Diff	cashtab-tests
Build 49025: arc lint + arc unit

Event Timeline

bytesofman created this revision.Aug 9 2023, 18:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 9 2023, 18:08

bytesofman requested review of this revision.Aug 9 2023, 18:08

Harbormaster completed remote builds in B24717: Diff 41760.Aug 9 2023, 18:11

This is an empty object, please look if you can get rid of it in a follow-up. AFAICT your problem is that you need a global, right ?

This revision is now accepted and ready to land.Aug 9 2023, 19:23

In D14364#321853, @Fabien wrote:

This is an empty object, please look if you can get rid of it in a follow-up. AFAICT your problem is that you need a global, right ?

good point.

Yes, we just need something that exists in one place so that it is easy to modify if and when we decide to cache more stuff.

Closed by commit rABC1e2863154acd: [Cashtab] Move defaultCashtabCache out of Ticker.js (authored by bytesofman). · Explain WhyAug 9 2023, 21:04

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC1e2863154acd: [Cashtab] Move defaultCashtabCache out of Ticker.js.