Page MenuHomePhabricator
Differential D14370

Remove the -deprecatedrpc=getblocktemplate_sigops rpc option
ClosedPublic
Actions

Authored by Fabien on Aug 11 2023, 16:01.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCbfac1975661b: Remove the -deprecatedrpc=getblocktemplate_sigops rpc option
Summary

This was added for compatibility reason in v0.26.8 which is old enough to be safely removed.

Depends on D14369.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
remove_deprecated_blocktemplatesigops
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24737
Build 49066: Build Difflint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 49065: arc lint + arc unit

Event Timeline

Fabien created this revision.Aug 11 2023, 16:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 11 2023, 16:01
Fabien requested review of this revision.Aug 11 2023, 16:01
Harbormaster completed remote builds in B24737: Diff 41786.Aug 11 2023, 16:30
Fabien updated this revision to Diff 41788.Aug 11 2023, 16:30

Rebase

Fabien added a child revision: D14371: Remove the -deprecatedrpc=softforks option.Aug 11 2023, 16:35
Harbormaster completed remote builds in B24739: Diff 41788.Aug 11 2023, 16:54
PiRK added a subscriber: PiRK.Aug 11 2023, 19:44
PiRK added inline comments.
test/functional/rpc_deprecated.py
16 ↗(On Diff #41788)

Could probably be removed in this diff, but OK if you land this with D14371

PiRK accepted this revision.Aug 11 2023, 19:45
This revision is now accepted and ready to land.Aug 11 2023, 19:45
Fabien added inline comments.Aug 11 2023, 19:50
test/functional/rpc_deprecated.py
16 ↗(On Diff #41788)

Good catch it's a rebase issue, I will fix it before landing

Closed by commit rABCbfac1975661b: Remove the -deprecatedrpc=getblocktemplate_sigops rpc option (authored by Fabien). · Explain WhyAug 11 2023, 22:19
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCbfac1975661b: Remove the -deprecatedrpc=getblocktemplate_sigops rpc option.

Revision Contents
Changeset List

PathSize
doc/
2 lines
src/
rpc/
25 lines
test/
functional/
33 lines

Diff 41786

View Options

doc/release-notes.md

Loading...
View Options

src/rpc/mining.cpp

Loading...
View Options

test/functional/rpc_deprecated.py

Loading...