Paths

Table of Contentst

Differential D14373

[Cashtab] Replace currency object with appConfig for everything except alias settings
ClosedPublic
Actions

Authored by bytesofman on Aug 11 2023, 20:57.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC5f85d7d68625: [Cashtab] Replace currency object with appConfig for everything except alias…

Summary

T3261

Replace currency object with appConfig for remaining settings that are not related to alias implementation

Test Plan

npm test, confirm organization is an improvement, does not introduce new ambiguities

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ticker-be-gone

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24763
Build 49118: Build Diff	cashtab-tests
Build 49117: arc lint + arc unit

Event Timeline

bytesofman created this revision.Aug 11 2023, 20:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 11 2023, 20:57

bytesofman requested review of this revision.Aug 11 2023, 20:57

bytesofman added inline comments.Aug 11 2023, 20:59

cashtab/src/components/Common/Notifications.js
194 ↗	(On Diff #41791)	`currency` isn't even being used here, the function is using the `currency` constant above. Again, existing bug, but no point in persisting it to not use new `appConfig` param
cashtab/src/utils/__tests__/validation.test.js
270 ↗	(On Diff #41791)	Note that there is no `currency.tokenDecimals` -- not sure where this artifact error was introduced, but no point in persisting it to the equally non-existent `appConfig.tokenDecimals`

Harbormaster completed remote builds in B24742: Diff 41791.Aug 11 2023, 20:59

PiRK accepted this revision.Aug 14 2023, 08:39

This revision is now accepted and ready to land.Aug 14 2023, 08:39

rebase

Harbormaster completed remote builds in B24763: Diff 41820.Aug 14 2023, 22:28

Closed by commit rABC5f85d7d68625: [Cashtab] Replace currency object with appConfig for everything except alias… (authored by bytesofman). · Explain WhyAug 14 2023, 22:28

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC5f85d7d68625: [Cashtab] Replace currency object with appConfig for everything except alias….

Revision Contents
Changeset List

Path

Size

cashtab/

src/

components/

Airdrop/

16 lines

Alias/

7 lines

Common/

BalanceHeaderFiat.js

4 lines

13 lines

EnhancedInputs.js

14 lines

Notifications.js

31 lines

6 lines

18 lines

Configure/

4 lines

Home/

10 lines

6 lines

OnBoarding/

4 lines

Receive/

6 lines

Send/

33 lines

2 lines

SignVerifyMsg/

SignVerifyMsg.js

10 lines

Tokens/

CreateTokenForm.js

4 lines

14 lines

__tests__/

CreateTokenForm.test.js

4 lines

	config/	app.js/
	components/	Common/


	Ticker.js

15 lines

hooks/

__tests__/

migrations.test.js

8 lines

8 lines

utils/

__mocks__/

4 lines

__tests__/

cashMethods.test.js

26 lines

transactions.test.js

36 lines

validation.test.js

138 lines

28 lines

4 lines

16 lines

transactions.js

9 lines

27 lines

Diff 41820

cashtab/src/components/Airdrop/Airdrop.js

Loading...

cashtab/src/components/Alias/Alias.js

Loading...

cashtab/src/components/Common/BalanceHeaderFiat.js

Loading...

cashtab/src/components/Common/CustomIcons.js

Loading...

cashtab/src/components/Common/EnhancedInputs.js

Loading...

cashtab/src/components/Common/Notifications.js

Loading...

cashtab/src/components/Common/QRCode.js

Loading...

cashtab/src/components/Common/Ticker.js

Loading...

cashtab/src/components/Configure/Configure.js

Loading...

cashtab/src/components/Home/Home.js

Loading...

cashtab/src/components/Home/Tx.js

Loading...

cashtab/src/components/OnBoarding/OnBoarding.js

Loading...

cashtab/src/components/Receive/Receive.js

Loading...

cashtab/src/components/Send/Send.js

Loading...

cashtab/src/components/Send/SendToken.js

Loading...

cashtab/src/components/SignVerifyMsg/SignVerifyMsg.js

Loading...

cashtab/src/components/Tokens/CreateTokenForm.js

Loading...

cashtab/src/components/Tokens/Tokens.js

Loading...

cashtab/src/components/Tokens/tests/CreateTokenForm.test.js

Loading...

cashtab/src/config/app.js

Loading...

cashtab/src/hooks/tests/migrations.test.js

Loading...

cashtab/src/hooks/useWallet.js

Loading...

cashtab/src/utils/mocks/sendBCH.js

Loading...

cashtab/src/utils/tests/cashMethods.test.js

Loading...

cashtab/src/utils/tests/transactions.test.js

Loading...

cashtab/src/utils/tests/validation.test.js

Loading...

cashtab/src/utils/cashMethods.js

Loading...

cashtab/src/utils/chronik.js

Loading...

cashtab/src/utils/formatting.js

Loading...

cashtab/src/utils/transactions.js

Loading...

cashtab/src/utils/validation.js

Loading...