Page MenuHomePhabricator
Differential D14413

show amounts in XEC for CTransaction in logs
ClosedPublic
Actions

Authored by PiRK on Aug 25 2023, 14:34.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCda4590fbcacf: show amounts in XEC for CTransaction in logs
Summary

CommitTransaction logs a string-serialized version of the transaction. The outputs were still shown in BCHA units. Fix it to show XEC amounts instead.

Note that this serialization code duplicates the FormatMoney function, but FormatMoney also needs to account for the -ecash argument, and we don't want to pull ArgsManager into libbitcoinconsensus.

Test Plan

Run wallet_basic.py with an assert False at the end, inspect the debug log and check that all CTransactions in the log show XEC amounts.

Search for usages of COIN in the codebase and check that it is not used in any other user-facing logs or outputs.

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Aug 25 2023, 14:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 25 2023, 14:34
PiRK requested review of this revision.Aug 25 2023, 14:34
PiRK retitled this revision from show amounts in XEC in logs to show amounts in XEC for CTransaction in logs.Aug 25 2023, 14:34
PiRK edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B24856: Diff 41949.Aug 25 2023, 14:38
teamcity added a comment.Aug 25 2023, 14:38
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[312/479] bitcoin: testing transaction_tests
FAILED: src/test/CMakeFiles/check-bitcoin-transaction_tests 
cd /work/abc-ci-builds/build-clang-tidy/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang-tidy/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang-tidy/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-clang-tidy/test/log/bitcoin-transaction_tests.log /work/abc-ci-builds/build-clang-tidy/src/test/test_bitcoin --run_test=transaction_tests --logger=HRF,message:JUNIT,message,bitcoin-transaction_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-clang-tidy/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-clang-tidy/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[313/479] Running avalanche test suite
PASSED: avalanche test suite
[314/479] pow: testing daa_tests
[315/479] Running utility command for check-pow-daa_tests
[316/479] pow: testing eda_tests
[317/479] Running utility command for check-pow-eda_tests
[318/479] Linking CXX executable src/seeder/test/test-seeder
[319/479] pow: testing grasberg_tests
[320/479] Running utility command for check-pow-grasberg_tests
[321/479] seeder: testing options_tests
[322/479] Running utility command for check-seeder-options_tests
[323/479] seeder: testing message_writer_tests
[324/479] Running utility command for check-seeder-message_writer_tests
[325/479] seeder: testing p2p_messaging_tests
[326/479] Running utility command for check-seeder-p2p_messaging_tests
[327/479] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/bitcoinaddressvalidatortests.cpp.o
[328/479] seeder: testing parse_name_tests
[329/479] Running utility command for check-seeder-parse_name_tests
[330/479] seeder: testing write_name_tests
[331/479] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/compattests.cpp.o
[332/479] Running utility command for check-seeder-write_name_tests
[333/479] Running seeder test suite
PASSED: seeder test suite
[334/479] Test Bitcoin RPC authentication...
...
----------------------------------------------------------------------
Ran 3 tests in 0.017s

OK
[335/479] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_bitcoin-qt_autogen/mocs_compilation.cpp.o
[336/479] cd /work/contrib/devtools/chainparams && /usr/bin/python3.9 ./test_make_chainparams.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.001s

OK
[337/479] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/guiutiltests.cpp.o
[338/479] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/util.cpp.o
[339/479] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/uritests.cpp.o
[340/479] pow: testing aserti32d_tests
[341/479] Running utility command for check-pow-aserti32d_tests
[342/479] Running pow test suite
PASSED: pow test suite
[343/479] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/apptests.cpp.o
[344/479] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/rpcnestedtests.cpp.o
[345/479] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_main.cpp.o
[346/479] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/__/__/wallet/test/wallet_test_fixture.cpp.o
[347/479] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/paymentservertests.cpp.o
[348/479] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/addressbooktests.cpp.o
[349/479] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o
[350/479] Linking CXX executable src/qt/test/test_bitcoin-qt
[351/479] bitcoin-qt: testing test_bitcoin-qt
[352/479] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
teamcity added a comment.Aug 25 2023, 14:41
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

cd /work/abc-ci-builds/build-clang/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-clang/test/log/bitcoin-wallet_tests.log /work/abc-ci-builds/build-clang/src/test/test_bitcoin --run_test=wallet_tests --logger=HRF,message:JUNIT,message,bitcoin-wallet_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-clang/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-clang/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[331/486] bitcoin: testing wallet_crypto_tests
FAILED: src/test/CMakeFiles/check-bitcoin-wallet_crypto_tests 
cd /work/abc-ci-builds/build-clang/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-clang/test/log/bitcoin-wallet_crypto_tests.log /work/abc-ci-builds/build-clang/src/test/test_bitcoin --run_test=wallet_crypto_tests --logger=HRF,message:JUNIT,message,bitcoin-wallet_crypto_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-clang/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-clang/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[332/486] bitcoin: testing txrequest_tests
FAILED: src/test/CMakeFiles/check-bitcoin-txrequest_tests 
cd /work/abc-ci-builds/build-clang/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-clang/test/log/bitcoin-txrequest_tests.log /work/abc-ci-builds/build-clang/src/test/test_bitcoin --run_test=txrequest_tests --logger=HRF,message:JUNIT,message,bitcoin-txrequest_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-clang/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-clang/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[333/486] bitcoin: testing walletdb_tests
FAILED: src/test/CMakeFiles/check-bitcoin-walletdb_tests 
cd /work/abc-ci-builds/build-clang/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-clang/test/log/bitcoin-walletdb_tests.log /work/abc-ci-builds/build-clang/src/test/test_bitcoin --run_test=walletdb_tests --logger=HRF,message:JUNIT,message,bitcoin-walletdb_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-clang/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-clang/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[334/486] bitcoin: testing denialofservice_tests
FAILED: src/test/CMakeFiles/check-bitcoin-denialofservice_tests 
cd /work/abc-ci-builds/build-clang/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-clang/test/log/bitcoin-denialofservice_tests.log /work/abc-ci-builds/build-clang/src/test/test_bitcoin --run_test=denialofservice_tests --logger=HRF,message:JUNIT,message,bitcoin-denialofservice_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-clang/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-clang/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[335/486] bitcoin: testing blockcheck_tests
FAILED: src/test/CMakeFiles/check-bitcoin-blockcheck_tests 
cd /work/abc-ci-builds/build-clang/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-clang/test/log/bitcoin-blockcheck_tests.log /work/abc-ci-builds/build-clang/src/test/test_bitcoin --run_test=blockcheck_tests --logger=HRF,message:JUNIT,message,bitcoin-blockcheck_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-clang/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-clang/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[336/486] bitcoin: testing miner_tests
FAILED: src/test/CMakeFiles/check-bitcoin-miner_tests 
cd /work/abc-ci-builds/build-clang/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-clang/test/log/bitcoin-miner_tests.log /work/abc-ci-builds/build-clang/src/test/test_bitcoin --run_test=miner_tests --logger=HRF,message:JUNIT,message,bitcoin-miner_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-clang/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-clang/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[337/486] bitcoin: testing init_tests
FAILED: src/test/CMakeFiles/check-bitcoin-init_tests 
cd /work/abc-ci-builds/build-clang/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-clang/test/log/bitcoin-init_tests.log /work/abc-ci-builds/build-clang/src/test/test_bitcoin --run_test=init_tests --logger=HRF,message:JUNIT,message,bitcoin-init_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-clang/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-clang/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[338/486] bitcoin: testing transaction_tests
FAILED: src/test/CMakeFiles/check-bitcoin-transaction_tests 
cd /work/abc-ci-builds/build-clang/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-clang/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-clang/test/log/bitcoin-transaction_tests.log /work/abc-ci-builds/build-clang/src/test/test_bitcoin --run_test=transaction_tests --logger=HRF,message:JUNIT,message,bitcoin-transaction_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-clang/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-clang/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[339/486] pow: testing aserti32d_tests
[340/486] Running utility command for check-pow-aserti32d_tests
[341/486] Running pow test suite
PASSED: pow test suite
[342/486] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/addressbooktests.cpp.o
[343/486] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o
[344/486] Linking CXX executable src/qt/test/test_bitcoin-qt
[345/486] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/fixture.cpp.o
[346/486] bitcoin-qt: testing test_bitcoin-qt
[347/486] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[348/486] Linking CXX executable src/seeder/test/test-seeder
[349/486] seeder: testing message_writer_tests
[350/486] seeder: testing options_tests
[351/486] seeder: testing p2p_messaging_tests
[352/486] seeder: testing parse_name_tests
[353/486] seeder: testing write_name_tests
[354/486] Running utility command for check-seeder-message_writer_tests
[355/486] Running utility command for check-seeder-options_tests
[356/486] Running utility command for check-seeder-p2p_messaging_tests
[357/486] Running utility command for check-seeder-parse_name_tests
[358/486] Running utility command for check-seeder-write_name_tests
[359/486] Running seeder test suite
PASSED: seeder test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
teamcity added a comment.Aug 25 2023, 14:43
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Tail of the build log:

cd /work/abc-ci-builds/build-without-wallet/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-without-wallet/test/log/bitcoin-net_peer_eviction_tests.log /work/abc-ci-builds/build-without-wallet/src/test/test_bitcoin --run_test=net_peer_eviction_tests --logger=HRF,message:JUNIT,message,bitcoin-net_peer_eviction_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-without-wallet/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-without-wallet/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[315/447] bitcoin: testing serialize_tests
FAILED: src/test/CMakeFiles/check-bitcoin-serialize_tests 
cd /work/abc-ci-builds/build-without-wallet/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-without-wallet/test/log/bitcoin-serialize_tests.log /work/abc-ci-builds/build-without-wallet/src/test/test_bitcoin --run_test=serialize_tests --logger=HRF,message:JUNIT,message,bitcoin-serialize_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-without-wallet/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-without-wallet/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[316/447] bitcoin: testing radix_tests
FAILED: src/test/CMakeFiles/check-bitcoin-radix_tests 
cd /work/abc-ci-builds/build-without-wallet/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-without-wallet/test/log/bitcoin-radix_tests.log /work/abc-ci-builds/build-without-wallet/src/test/test_bitcoin --run_test=radix_tests --logger=HRF,message:JUNIT,message,bitcoin-radix_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-without-wallet/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-without-wallet/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[317/447] bitcoin: testing random_tests
FAILED: src/test/CMakeFiles/check-bitcoin-random_tests 
cd /work/abc-ci-builds/build-without-wallet/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-without-wallet/test/log/bitcoin-random_tests.log /work/abc-ci-builds/build-without-wallet/src/test/test_bitcoin --run_test=random_tests --logger=HRF,message:JUNIT,message,bitcoin-random_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-without-wallet/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-without-wallet/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[318/447] bitcoin: testing net_tests
FAILED: src/test/CMakeFiles/check-bitcoin-net_tests 
cd /work/abc-ci-builds/build-without-wallet/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-without-wallet/test/log/bitcoin-net_tests.log /work/abc-ci-builds/build-without-wallet/src/test/test_bitcoin --run_test=net_tests --logger=HRF,message:JUNIT,message,bitcoin-net_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-without-wallet/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-without-wallet/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[319/447] bitcoin: testing reverselock_tests
FAILED: src/test/CMakeFiles/check-bitcoin-reverselock_tests 
cd /work/abc-ci-builds/build-without-wallet/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-without-wallet/test/log/bitcoin-reverselock_tests.log /work/abc-ci-builds/build-without-wallet/src/test/test_bitcoin --run_test=reverselock_tests --logger=HRF,message:JUNIT,message,bitcoin-reverselock_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-without-wallet/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-without-wallet/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[320/447] bitcoin: testing policy_block_tests
FAILED: src/test/CMakeFiles/check-bitcoin-policy_block_tests 
cd /work/abc-ci-builds/build-without-wallet/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-without-wallet/test/log/bitcoin-policy_block_tests.log /work/abc-ci-builds/build-without-wallet/src/test/test_bitcoin --run_test=policy_block_tests --logger=HRF,message:JUNIT,message,bitcoin-policy_block_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-without-wallet/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-without-wallet/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[321/447] bitcoin: testing script_commitment_tests
FAILED: src/test/CMakeFiles/check-bitcoin-script_commitment_tests 
cd /work/abc-ci-builds/build-without-wallet/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-without-wallet/test/log/bitcoin-script_commitment_tests.log /work/abc-ci-builds/build-without-wallet/src/test/test_bitcoin --run_test=script_commitment_tests --logger=HRF,message:JUNIT,message,bitcoin-script_commitment_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-without-wallet/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-without-wallet/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[322/447] bitcoin: testing script_p2sh_tests
FAILED: src/test/CMakeFiles/check-bitcoin-script_p2sh_tests 
cd /work/abc-ci-builds/build-without-wallet/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-without-wallet/test/log/bitcoin-script_p2sh_tests.log /work/abc-ci-builds/build-without-wallet/src/test/test_bitcoin --run_test=script_p2sh_tests --logger=HRF,message:JUNIT,message,bitcoin-script_p2sh_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-without-wallet/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-without-wallet/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[323/447] bitcoin: testing torcontrol_tests
FAILED: src/test/CMakeFiles/check-bitcoin-torcontrol_tests 
cd /work/abc-ci-builds/build-without-wallet/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-without-wallet/test/log/bitcoin-torcontrol_tests.log /work/abc-ci-builds/build-without-wallet/src/test/test_bitcoin --run_test=torcontrol_tests --logger=HRF,message:JUNIT,message,bitcoin-torcontrol_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-without-wallet/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-without-wallet/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[324/447] bitcoin: testing txvalidationcache_tests
FAILED: src/test/CMakeFiles/check-bitcoin-txvalidationcache_tests 
cd /work/abc-ci-builds/build-without-wallet/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-without-wallet/test/log/bitcoin-txvalidationcache_tests.log /work/abc-ci-builds/build-without-wallet/src/test/test_bitcoin --run_test=txvalidationcache_tests --logger=HRF,message:JUNIT,message,bitcoin-txvalidationcache_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-without-wallet/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-without-wallet/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[325/447] bitcoin: testing transaction_tests
FAILED: src/test/CMakeFiles/check-bitcoin-transaction_tests 
cd /work/abc-ci-builds/build-without-wallet/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-without-wallet/test/log/bitcoin-transaction_tests.log /work/abc-ci-builds/build-without-wallet/src/test/test_bitcoin --run_test=transaction_tests --logger=HRF,message:JUNIT,message,bitcoin-transaction_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-without-wallet/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-without-wallet/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[326/447] bitcoin: testing util_threadnames_tests
FAILED: src/test/CMakeFiles/check-bitcoin-util_threadnames_tests 
cd /work/abc-ci-builds/build-without-wallet/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-without-wallet/test/log/bitcoin-util_threadnames_tests.log /work/abc-ci-builds/build-without-wallet/src/test/test_bitcoin --run_test=util_threadnames_tests --logger=HRF,message:JUNIT,message,bitcoin-util_threadnames_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-without-wallet/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-without-wallet/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[327/447] bitcoin: testing validation_chainstatemanager_tests
FAILED: src/test/CMakeFiles/check-bitcoin-validation_chainstatemanager_tests 
cd /work/abc-ci-builds/build-without-wallet/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-without-wallet/test/log/bitcoin-validation_chainstatemanager_tests.log /work/abc-ci-builds/build-without-wallet/src/test/test_bitcoin --run_test=validation_chainstatemanager_tests --logger=HRF,message:JUNIT,message,bitcoin-validation_chainstatemanager_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-without-wallet/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-without-wallet/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[328/447] bitcoin: testing validation_tests
FAILED: src/test/CMakeFiles/check-bitcoin-validation_tests 
cd /work/abc-ci-builds/build-without-wallet/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-without-wallet/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-without-wallet/test/log/bitcoin-validation_tests.log /work/abc-ci-builds/build-without-wallet/src/test/test_bitcoin --run_test=validation_tests --logger=HRF,message:JUNIT,message,bitcoin-validation_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-without-wallet/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-without-wallet/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1
teamcity added a comment.Aug 25 2023, 14:47
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

[326/487] bitcoin: testing scriptpubkeyman_tests
FAILED: src/test/CMakeFiles/check-bitcoin-scriptpubkeyman_tests 
cd /work/abc-ci-builds/build-debug/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-debug/test/log/bitcoin-scriptpubkeyman_tests.log /work/abc-ci-builds/build-debug/src/test/test_bitcoin --run_test=scriptpubkeyman_tests --logger=HRF,message:JUNIT,message,bitcoin-scriptpubkeyman_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-debug/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-debug/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[327/487] bitcoin: testing psbt_wallet_tests
FAILED: src/test/CMakeFiles/check-bitcoin-psbt_wallet_tests 
cd /work/abc-ci-builds/build-debug/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-debug/test/log/bitcoin-psbt_wallet_tests.log /work/abc-ci-builds/build-debug/src/test/test_bitcoin --run_test=psbt_wallet_tests --logger=HRF,message:JUNIT,message,bitcoin-psbt_wallet_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-debug/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-debug/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[328/487] bitcoin: testing wallet_tests
FAILED: src/test/CMakeFiles/check-bitcoin-wallet_tests 
cd /work/abc-ci-builds/build-debug/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-debug/test/log/bitcoin-wallet_tests.log /work/abc-ci-builds/build-debug/src/test/test_bitcoin --run_test=wallet_tests --logger=HRF,message:JUNIT,message,bitcoin-wallet_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-debug/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-debug/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[329/487] bitcoin: testing walletdb_tests
FAILED: src/test/CMakeFiles/check-bitcoin-walletdb_tests 
cd /work/abc-ci-builds/build-debug/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-debug/test/log/bitcoin-walletdb_tests.log /work/abc-ci-builds/build-debug/src/test/test_bitcoin --run_test=walletdb_tests --logger=HRF,message:JUNIT,message,bitcoin-walletdb_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-debug/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-debug/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[330/487] bitcoin: testing wallet_crypto_tests
FAILED: src/test/CMakeFiles/check-bitcoin-wallet_crypto_tests 
cd /work/abc-ci-builds/build-debug/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-debug/test/log/bitcoin-wallet_crypto_tests.log /work/abc-ci-builds/build-debug/src/test/test_bitcoin --run_test=wallet_crypto_tests --logger=HRF,message:JUNIT,message,bitcoin-wallet_crypto_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-debug/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-debug/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[332/487] bitcoin: testing txrequest_tests
FAILED: src/test/CMakeFiles/check-bitcoin-txrequest_tests 
cd /work/abc-ci-builds/build-debug/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-debug/test/log/bitcoin-txrequest_tests.log /work/abc-ci-builds/build-debug/src/test/test_bitcoin --run_test=txrequest_tests --logger=HRF,message:JUNIT,message,bitcoin-txrequest_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-debug/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-debug/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[333/487] bitcoin: testing blockcheck_tests
FAILED: src/test/CMakeFiles/check-bitcoin-blockcheck_tests 
cd /work/abc-ci-builds/build-debug/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-debug/test/log/bitcoin-blockcheck_tests.log /work/abc-ci-builds/build-debug/src/test/test_bitcoin --run_test=blockcheck_tests --logger=HRF,message:JUNIT,message,bitcoin-blockcheck_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-debug/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-debug/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[334/487] bitcoin: testing logging_tests
FAILED: src/test/CMakeFiles/check-bitcoin-logging_tests 
cd /work/abc-ci-builds/build-debug/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-debug/test/log/bitcoin-logging_tests.log /work/abc-ci-builds/build-debug/src/test/test_bitcoin --run_test=logging_tests --logger=HRF,message:JUNIT,message,bitcoin-logging_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-debug/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-debug/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[335/487] bitcoin: testing denialofservice_tests
FAILED: src/test/CMakeFiles/check-bitcoin-denialofservice_tests 
cd /work/abc-ci-builds/build-debug/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-debug/test/log/bitcoin-denialofservice_tests.log /work/abc-ci-builds/build-debug/src/test/test_bitcoin --run_test=denialofservice_tests --logger=HRF,message:JUNIT,message,bitcoin-denialofservice_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-debug/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-debug/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[336/487] bitcoin: testing init_tests
FAILED: src/test/CMakeFiles/check-bitcoin-init_tests 
cd /work/abc-ci-builds/build-debug/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-debug/test/log/bitcoin-init_tests.log /work/abc-ci-builds/build-debug/src/test/test_bitcoin --run_test=init_tests --logger=HRF,message:JUNIT,message,bitcoin-init_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-debug/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-debug/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[338/487] bitcoin: testing uint256_tests
FAILED: src/test/CMakeFiles/check-bitcoin-uint256_tests 
cd /work/abc-ci-builds/build-debug/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-debug/test/log/bitcoin-uint256_tests.log /work/abc-ci-builds/build-debug/src/test/test_bitcoin --run_test=uint256_tests --logger=HRF,message:JUNIT,message,bitcoin-uint256_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-debug/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-debug/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[339/487] bitcoin: testing transaction_tests
FAILED: src/test/CMakeFiles/check-bitcoin-transaction_tests 
cd /work/abc-ci-builds/build-debug/src/test && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/junit && /usr/bin/cmake -E make_directory /work/abc-ci-builds/build-debug/test/log && /usr/bin/cmake -E env /work/cmake/utils/log-and-print-on-failure.sh /work/abc-ci-builds/build-debug/test/log/bitcoin-transaction_tests.log /work/abc-ci-builds/build-debug/src/test/test_bitcoin --run_test=transaction_tests --logger=HRF,message:JUNIT,message,bitcoin-transaction_tests.xml --catch_system_errors=no
/work/abc-ci-builds/build-debug/src/test/test_bitcoin: symbol lookup error: /work/abc-ci-builds/build-debug/src/libbitcoinconsensus.so.0: undefined symbol: _Z17G_TRANSLATION_FUNB5cxx11
[342/487] Running seeder test suite
PASSED: seeder test suite
[351/487] Running secp256k1 test suite
PASSED: secp256k1 test suite
[353/487] Running pow test suite
PASSED: pow test suite
[356/487] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[359/487] Running avalanche test suite
PASSED: avalanche test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1
teamcity added a comment.Aug 25 2023, 14:50
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

wallet_groups.py                          | ✓ Passed  | 12 s
wallet_hd.py                              | ✓ Passed  | 6 s
wallet_hd.py --descriptors                | ✓ Passed  | 4 s
wallet_import_rescan.py                   | ✓ Passed  | 6 s
wallet_import_with_label.py               | ✓ Passed  | 1 s
wallet_importdescriptors.py               | ✓ Passed  | 3 s
wallet_importmulti.py                     | ✓ Passed  | 2 s
wallet_importprunedfunds.py               | ✓ Passed  | 2 s
wallet_importprunedfunds.py --descriptors | ✓ Passed  | 1 s
wallet_keypool.py                         | ✓ Passed  | 3 s
wallet_keypool_topup.py                   | ✓ Passed  | 3 s
wallet_keypool_topup.py --descriptors     | ✓ Passed  | 2 s
wallet_labels.py                          | ✓ Passed  | 1 s
wallet_labels.py --descriptors            | ✓ Passed  | 1 s
wallet_listreceivedby.py                  | ✓ Passed  | 5 s
wallet_listsinceblock.py                  | ✓ Passed  | 5 s
wallet_listsinceblock.py --descriptors    | ✓ Passed  | 2 s
wallet_listtransactions.py                | ✓ Passed  | 4 s
wallet_listtransactions.py --descriptors  | ✓ Passed  | 3 s
wallet_multiwallet.py                     | ✓ Passed  | 39 s
wallet_multiwallet.py --usecli            | ✓ Passed  | 9 s
wallet_reorgsrestore.py                   | ✓ Passed  | 3 s
wallet_resendwallettransactions.py        | ✓ Passed  | 2 s
wallet_send.py                            | ✓ Passed  | 9 s
wallet_startup.py                         | ✓ Passed  | 2 s
wallet_timelock.py                        | ✓ Passed  | 1 s
wallet_txn_clone.py                       | ✓ Passed  | 1 s
wallet_txn_clone.py --mineblock           | ✓ Passed  | 2 s
wallet_txn_doublespend.py                 | ✓ Passed  | 1 s
wallet_txn_doublespend.py --mineblock     | ✓ Passed  | 2 s
wallet_watchonly.py                       | ✓ Passed  | 1 s
wallet_watchonly.py --usecli              | ✓ Passed  | 1 s
chronik_avalanche.py                      | ○ Skipped | 0 s
chronik_block.py                          | ○ Skipped | 0 s
chronik_block_info.py                     | ○ Skipped | 0 s
chronik_block_txs.py                      | ○ Skipped | 0 s
chronik_blockchain_info.py                | ○ Skipped | 0 s
chronik_blocks.py                         | ○ Skipped | 0 s
chronik_disallow_prune.py                 | ○ Skipped | 0 s
chronik_pause.py                          | ○ Skipped | 0 s
chronik_raw_tx.py                         | ○ Skipped | 0 s
chronik_resync.py                         | ○ Skipped | 0 s
chronik_script_confirmed_txs.py           | ○ Skipped | 0 s
chronik_script_history.py                 | ○ Skipped | 0 s
chronik_script_unconfirmed_txs.py         | ○ Skipped | 0 s
chronik_script_utxos.py                   | ○ Skipped | 0 s
chronik_serve.py                          | ○ Skipped | 0 s
chronik_spent_by.py                       | ○ Skipped | 0 s
chronik_tx.py                             | ○ Skipped | 0 s
chronik_ws.py                             | ○ Skipped | 0 s
chronik_ws_script.py                      | ○ Skipped | 0 s
interface_usdt_net.py                     | ○ Skipped | 0 s
interface_usdt_utxocache.py               | ○ Skipped | 0 s
interface_usdt_validation.py              | ○ Skipped | 0 s

ALL                                       | ✓ Passed  | 1215 s (accumulated) 
Runtime: 243 s

ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1
PiRK planned changes to this revision.Aug 25 2023, 15:26
PiRK updated this revision to Diff 41970.Aug 28 2023, 14:02

reintroduce CASH, so that we don't need to pull ArgsManager into libbitcoinconsensus

Now amount.h is included as header-only in transaction.cpp

PiRK edited the test plan for this revision. (Show Details)Aug 28 2023, 14:03
Harbormaster completed remote builds in B24873: Diff 41970.Aug 28 2023, 14:22
PiRK edited the summary of this revision. (Show Details)Aug 29 2023, 06:31
Fabien requested changes to this revision.Aug 29 2023, 07:25
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/consensus/amount.h
145

At least call it ECASH, but if it's the single use maybe using 100 * SATOSHI directly is fine

This revision now requires changes to proceed.Aug 29 2023, 07:25
PiRK updated this revision to Diff 41976.Aug 29 2023, 08:31

don't reintroduce ECASH for two callsites

Harbormaster completed remote builds in B24879: Diff 41976.Aug 29 2023, 08:50
Fabien accepted this revision.Aug 29 2023, 17:51
Fabien added inline comments.
src/primitives/transaction.cpp
36 ↗(On Diff #41976)

const

This revision is now accepted and ready to land.Aug 29 2023, 17:51
PiRK updated this revision to Diff 41998.Aug 30 2023, 06:04

const

Harbormaster completed remote builds in B24894: Diff 41998.Aug 30 2023, 06:20
Closed by commit rABCda4590fbcacf: show amounts in XEC for CTransaction in logs (authored by PiRK). · Explain WhyAug 30 2023, 10:22
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCda4590fbcacf: show amounts in XEC for CTransaction in logs.

Revision Contents
Changeset List

PathSize
src/
consensus/
1 line
2 lines
primitives/
4 lines

Diff 41970

View Options

src/consensus/amount.h

Loading...
View Options

src/consensus/amount.cpp

Loading...
View Options

src/primitives/transaction.cpp

Loading...