[qa] Fix error in calculating transaction fees.
ClosedPublic
Actions

Authored by schancel on Jul 4 2018, 16:05.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGf1fc09579f02: [qa] Fix error in calculating transaction fees.
rABCf1fc09579f02: [qa] Fix error in calculating transaction fees.

Summary

As per title

Test Plan

./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix-fee-bug

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2801
Build 3712: Bitcoin ABC Buildbot (legacy)
Build 3711: arc lint + arc unit

Event Timeline

schancel created this revision.Jul 4 2018, 16:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 4 2018, 16:05

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

jasonbcox added a subscriber: jasonbcox.Jul 4 2018, 16:08

jasonbcox added inline comments.

test/functional/test_framework/test_node.py
168	PLEASE write a comment above this line that indicates relay_fee is in sat per kb, which explains the divide by 1000. It's not obvious by looking at this line by itself.

Added a comment

jasonbcox accepted this revision.Jul 4 2018, 16:14

This revision is now accepted and ready to land.Jul 4 2018, 16:14

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B2801: Diff 4204.Jul 4 2018, 16:40

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2802: Diff 4205.Jul 4 2018, 16:49

Closed by commit rABCf1fc09579f02: [qa] Fix error in calculating transaction fees. (authored by schancel). · Explain WhyJul 4 2018, 18:36

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

test_node.py

2 lines

Diff 4204

View Options

test/functional/test_framework/test_node.py

[qa] Fix error in calculating transaction fees.ClosedPublicActions