T3278
Prevent 'NaN' from being rendered for extension open by link with amount unspecified
Details
Details
- Reviewers
emack - Group Reviewers
Restricted Project - Commits
- rABCb667161db2a4: [Cashtab] Fix NaN render bug in paybutton links without specified amount
npm test
npm run extension
load in browser
test donation button at bottom of https://coin.dance/ and opens without NaN msg
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- cashtab-nan-fix
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 25008 Build 49604: Build Diff cashtab-tests Build 49603: arc lint + arc unit
Event Timeline
| cashtab/extension/public/manifest.json | ||
|---|---|---|
| 6 | note that this bug is only in the extension. | |
| cashtab/src/components/Send/Send.js | ||
| 971 | without this, the user may click "send" before entering a value, and then needs to wait for a validation error | |
| cashtab/src/components/Send/__tests__/__snapshots__/Send.test.js.snap | ||
| 1 | Note: these used to be hidden with @generated, but they should be included in review as their changes should be consistent with changes in the diff | |