Paths

Table of Contentst

Differential D14479

[ecash-herald] Restrict length of unknown op-return msgs
ClosedPublic
Actions

Authored by bytesofman on Sep 13 2023, 17:58.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC39547735be35: [ecash-herald] Restrict length of unknown op-return msgs

Summary

Intended impact of printing hex for non-ascii OP_RETURN msgs without a known parsing schema was to improve aesthetics of msgs. This isn't done when the unknown msgs are also very large.

In such cases, abbreviate the msgs.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

limit-length-unknown-opreturn

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25016
Build 49620: Build Diff	ecash-herald-tests
Build 49619: arc lint + arc unit

Event Timeline

bytesofman created this revision.Sep 13 2023, 17:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 13 2023, 17:58

bytesofman requested review of this revision.Sep 13 2023, 17:58

before:

after:

Harbormaster completed remote builds in B25016: Diff 42177.Sep 13 2023, 17:59

PiRK accepted this revision.Sep 14 2023, 06:12

This revision is now accepted and ready to land.Sep 14 2023, 06:12

Closed by commit rABC39547735be35: [ecash-herald] Restrict length of unknown op-return msgs (authored by bytesofman). · Explain WhySep 14 2023, 17:05

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC39547735be35: [ecash-herald] Restrict length of unknown op-return msgs.

Revision Contents
Changeset List

Path

Size

apps/

ecash-herald/

src/

parse.js

6 lines

test/

mocks/

block.js

6 lines

Diff 42177

View Options

apps/ecash-herald/src/parse.js