Page MenuHomePhabricator
Differential D1553

Remove BIP9 related result and arguments from getblocktemplate
ClosedPublic
Actions

Authored by deadalnix on Jul 10 2018, 11:31.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGb1af4f69c925: Remove BIP9 related result and arguments from getblocktemplate
rABCb1af4f69c925: Remove BIP9 related result and arguments from getblocktemplate
Summary

As per title.

Depends on D1546

Test Plan
make check
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
rpcminingbip9
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2830
Build 3764: Bitcoin ABC Buildbot (legacy)
Build 3763: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 10 2018, 11:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 10 2018, 11:31
teamcity added a subscriber: teamcity.Jul 10 2018, 11:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 10 2018, 12:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2829: Diff 4247.Jul 10 2018, 12:14
deadalnix updated this revision to Diff 4248.Jul 10 2018, 12:58

Remove dead gbt_vb_name function

teamcity added a comment.Jul 10 2018, 12:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 10 2018, 13:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B2830: Diff 4248!Jul 10 2018, 13:40
jasonbcox accepted this revision.Jul 10 2018, 15:05
jasonbcox added a subscriber: jasonbcox.

Great! Less garbage to stare at while modifying GBT.

This revision is now accepted and ready to land.Jul 10 2018, 15:05
deadalnix updated this revision to Diff 4268.Jul 10 2018, 23:14

rebase

teamcity added a comment.Jul 10 2018, 23:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 10 2018, 23:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2845: Diff 4268.Jul 10 2018, 23:56
Closed by commit rABCb1af4f69c925: Remove BIP9 related result and arguments from getblocktemplate (authored by deadalnix). · Explain WhyJul 11 2018, 00:41
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
doc/
2 lines
src/
rpc/
116 lines

Diff 4248

View Options

doc/release-notes.md

Loading...
View Options

src/rpc/mining.cpp

Loading...