Page MenuHomePhabricator

[avalanche] Document the staking rewards enable flag
ClosedPublic

Authored by Fabien on Oct 11 2023, 12:23.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC21d92f22eaa5: [avalanche] Document the staking rewards enable flag
Summary

This used to be a hidden flag, make it available via the help.

Test Plan
bitcoind -help

Check the flag is properly documented.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_staking_rewards_flag_doc
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25323
Build 50227: Build Diffbuild-without-wallet · build-debug · build-clang-tidy · build-diff · lint-circular-dependencies · build-clang
Build 50226: arc lint + arc unit

Event Timeline

Fabien requested review of this revision.Oct 11 2023, 12:23
bytesofman added a subscriber: bytesofman.

see inline for possible formatting nit

src/init.cpp
1284–1285

is this indentation intended? seems to be causing the phab feedback of "hey this other arg was removed", even tho seems to have just been indented here.

This revision is now accepted and ready to land.Oct 11 2023, 12:28
src/init.cpp
1284–1285

This is a bug, I added a trailing comma instead of a semicolon. Funnily it compiles and works as expected!