Help people who need instructions for how to actually upgrade their node
Details
Details
- Reviewers
johnkuney Fabien - Group Reviewers
Restricted Project - Commits
- rABCafbbbc44f889: [e.cash] Add instructions on how to upgrade a node
Run it locally to see that it looks good.
Follow the instructions to check that they work.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- e.cash-upgrade-instructions
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 25339 Build 50259: Build Diff Build 50258: arc lint + arc unit
Event Timeline
| web/e.cash/pages/upgrade.js | ||
|---|---|---|
| 96 ↗ | (On Diff #42647) | dont put the <ul> inside <p>. This was causing that error you were seeing |
| 98 ↗ | (On Diff #42647) | may look cleaner with a <br /> between the line and the code. And could maybe add more space between list items. Could make a styled component for the list and add margin or padding to the list items |
Comment Actions
Fix error due to <ul> tag inside <p>
Use breaks to separate code from the preceding words
Comment Actions
OK, I fixed the broken part, and added breaks before the code.
I don't know how to do the styled component stuff, so I'll leave that part out.
Comment Actions
Looks good. Only nit is lose the spaces between the colons and the <br />'s, and up to you but maybe make it an ordered list <ol> instead if these steps are meant to be done in order
Comment Actions
Looks like the linter moved the <br /> tags to new lines anyway.
I changed the outer list, but left the sub-list unordered because: 1) it looks better that way, and 2) those commands don't need to be done in order
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.104.128:41876 for the next 60 minutes.