Page MenuHomePhabricator

[e.cash] Add mining page
ClosedPublic

Authored by Mengerian on Oct 23 2023, 17:50.

Details

Reviewers
Fabien
johnkuney
Group Reviewers
Restricted Project
Commits
rABCc1e10bf186a3: [e.cash] Add mining page
Summary

Makes a convenient place to gather all relevent information, and a nice link

Test Plan

Run it locally
Read it through to check the information.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
e.cash-mining
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25399
Build 50379: Build Diff
Build 50378: arc lint + arc unit

Event Timeline

Tail of the build log:

#4 extracting sha256:ee7d78be1eb92caf6ae84fc3af736b23eca018d5dedc967ae5bdee6d7082403b
#4 extracting sha256:ee7d78be1eb92caf6ae84fc3af736b23eca018d5dedc967ae5bdee6d7082403b done
#4 DONE 7.9s

#6 [2/4] COPY . .
#6 sha256:c0bff9a63461c3269a8c63b670a31db338befb4710c62c42754c282e649188fa
#6 DONE 0.9s

#7 [3/4] RUN npm ci
#7 sha256:05d533674b28695f919adb062d532c0fcd8690c7916d6b72cc03cf5125a2aea7
#7 9.800 
#7 9.800 added 811 packages, and audited 812 packages in 9s
#7 9.800 
#7 9.800 153 packages are looking for funding
#7 9.800   run `npm fund` for details
#7 9.831 
#7 9.831 7 vulnerabilities (6 moderate, 1 critical)
#7 9.831 
#7 9.831 To address issues that do not require attention, run:
#7 9.831   npm audit fix
#7 9.831 
#7 9.831 To address all issues, run:
#7 9.831   npm audit fix --force
#7 9.831 
#7 9.831 Run `npm audit` for details.
#7 9.832 npm notice 
#7 9.832 npm notice New major version of npm available! 8.19.4 -> 10.2.1
#7 9.832 npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.1>
#7 9.832 npm notice Run `npm install -g npm@10.2.1` to update!
#7 9.832 npm notice 
#7 DONE 10.5s

#8 [4/4] RUN npm run build
#8 sha256:6ab3658f4b6b06879945091e7f89e0be199f0540ca068081ca28dfc92262cc9f
#8 0.788 
#8 0.788 > e.cash@0.0.1 build
#8 0.788 > next build
#8 0.788 
#8 1.150 Attention: Next.js now collects completely anonymous telemetry regarding usage.
#8 1.150 This information is used to shape Next.js' roadmap and prioritize features.
#8 1.150 You can learn more, including how to opt-out if you'd not like to participate in this anonymous program, by visiting the following URL:
#8 1.150 https://nextjs.org/telemetry
#8 1.150 
#8 1.241 info  - Linting and checking validity of types...
#8 3.658 
#8 3.658 Failed to compile.
#8 3.658 
#8 3.658 ./pages/mining.js
#8 3.658 57:38  Error: `"` can be escaped with `&quot;`, `&ldquo;`, `&#34;`, `&rdquo;`.  react/no-unescaped-entities
#8 3.658 57:48  Error: `"` can be escaped with `&quot;`, `&ldquo;`, `&#34;`, `&rdquo;`.  react/no-unescaped-entities
#8 3.658 143:67  Error: `"` can be escaped with `&quot;`, `&ldquo;`, `&#34;`, `&rdquo;`.  react/no-unescaped-entities
#8 3.658 143:78  Error: `"` can be escaped with `&quot;`, `&ldquo;`, `&#34;`, `&rdquo;`.  react/no-unescaped-entities
#8 3.658 
#8 3.658 info  - Need to disable some ESLint rules? Learn more here: https://nextjs.org/docs/basic-features/eslint#disabling-rules
#8 ERROR: executor failed running [/bin/sh -c npm run build]: exit code: 1
------
 > [4/4] RUN npm run build:
------
executor failed running [/bin/sh -c npm run build]: exit code: 1
Build preview-e.cash failed with exit code 1
Fabien requested changes to this revision.Oct 23 2023, 19:32
Fabien added inline comments.
web/e.cash/pages/mining.js
60 ↗(On Diff #42733)
112 ↗(On Diff #42733)
138–140 ↗(On Diff #42733)
148 ↗(On Diff #42733)

I would put both the miner fund and the staking rewards together, along with an example output of the coinbasetxn field of the getblocktemplate

This revision now requires changes to proceed.Oct 23 2023, 19:32
Mengerian marked 3 inline comments as done.

Minor edits per review comments
Add example of expected output from getblocktemplate

To do: Make a codeblock component, rather then using inline styles. that can be in another Diff though

web/e.cash/pages/mining.js
160 ↗(On Diff #42762)
161 ↗(On Diff #42762)
Fabien requested changes to this revision.Oct 25 2023, 08:19

I think one more thing miner nodes should do is to ensure they have good connectivity with recommendations like:

  • Make sure the node accepts inbound connections
  • Make sure the node accepts both IPv4 and IPv6
  • Make sure there is no restriction in the number of connections (no maxconnection config set)
  • etc.
web/e.cash/pages/mining.js
156 ↗(On Diff #42762)

Since this is the default, I think we should rather say should not have avalanche disabled (it is enabled by default)

This revision now requires changes to proceed.Oct 25 2023, 08:19
Mengerian marked 3 inline comments as done.

Minor editing fixes
Add point about ensuring the node has good connectivity

Couple nits but lgtm

web/e.cash/pages/mining.js
155–156 ↗(On Diff #42790)

Nit'ing myself here: avoid double negation

165–166 ↗(On Diff #42790)
This revision is now accepted and ready to land.Oct 25 2023, 15:08
Mengerian marked 2 inline comments as done.

Fix nits

This revision was automatically updated to reflect the committed changes.