Would be useful for a registering user to know if there are pending registration txs already on the network for an alias he is attempting to register
Details
Details
- Reviewers
emack - Group Reviewers
Restricted Project - Commits
- rABC62a837e56827: [alias-server] Return pending registrations for a specified alias
npm test
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- alias-pending-by-alias
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 25425 Build 50431: Build Diff alias-server-tests Build 50430: arc lint + arc unit
Event Timeline
Comment Actions
Worth noting this would be implemented at the point of pressing the register button and not when the user is inputting the alias name with each keystroke being parsed for validity. I can add it as a conditional text render in the registration confirmation modal (preparePreviewModal).
Can I confirm we're still retaining the existing wallet specific pending list from the /address/ endpoint? The Pending Aliases dropdown will still display pending aliases associated with the active wallet and I will replace the pending check logic in D14611 so that it will compare with the pending prop from this /alias/ endpoint response.
Comment Actions
Can I confirm we're still retaining the existing wallet specific pending list from the /address/ endpoint?
Yes, this doesn't alter existing endpoints. Just adds pending info to the /alias/ endpoint.
I'm not clear on what your requested changes are based on the feedback, marking 'request review'