Page MenuHomePhabricator

[electrum] implement removal of coins in the proof editor
ClosedPublic

Authored by PiRK on Nov 9 2023, 14:07.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCdcf5792b97bd: [electrum] implement removal of coins in the proof editor
Summary

Allow removal of coins from the proof editor tool, using either a button at the end of the line or a context menu (allows deleting multiple coins at once)

This has been requested a lot, because the alternative is to manually delete the coins from the JSON file before loading it.

Depends on D14760

Test Plan

Open the proof editor with multiple coins, try the various methods for deleting coins: the red cross button, the context menu with single selection or multiple selection.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
proof_delete_coins
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25579
Build 50739: Build Diffelectrum-tests
Build 50738: arc lint + arc unit

Event Timeline

PiRK requested review of this revision.Nov 9 2023, 14:07
PiRK planned changes to this revision.Nov 9 2023, 14:12

the svg obviously need some optimization, 140 kB for a red cross is a bit excessive

export the icon as plain svg with Inkscape, check that the license metadata is preserved and the resulting file is a lot more compact.

This revision is now accepted and ready to land.Nov 9 2023, 14:49