Paths

Table of Contentst

Differential D14775

fix OSX build failure related to Span deduction guide in macro
ClosedPublic
Actions

Authored by PiRK on Nov 13 2023, 08:02.

Tags

None

Subscribers

None

Tokens

"Haypence" token, awarded by teamcity.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC31adc3630ad3: fix OSX build failure related to Span deduction guide in macro

Summary

It seems that some compilers don't support user-defined deduction guides (D14768) wrapped in macros.
So create the Span before using it in READWRITE.

Test Plan

ninja all check-all
build osx

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_span_in_macro

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25599
Build 50779: Build Diff	build-debug · lint-circular-dependencies · build-without-wallet · build-diff · build-clang-tidy · build-clang
Build 50778: arc lint + arc unit

Event Timeline

PiRK created this revision.Nov 13 2023, 08:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 13 2023, 08:02

@bot build-osx gitian-osx

teamcity awarded a token.Nov 13 2023, 08:04

Harbormaster completed remote builds in B25599: Diff 43049.Nov 13 2023, 08:22

PiRK published this revision for review.Nov 13 2023, 08:32

PiRK edited the test plan for this revision. (Show Details)

Fabien accepted this revision.Nov 13 2023, 08:46

This revision is now accepted and ready to land.Nov 13 2023, 08:46

Closed by commit rABC31adc3630ad3: fix OSX build failure related to Span deduction guide in macro (authored by PiRK). · Explain WhyNov 13 2023, 08:52

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC31adc3630ad3: fix OSX build failure related to Span deduction guide in macro.

Revision Contents
Changeset List

Path

Size

src/

3 lines

Diff 43049

src/netaddress.h

Loading...