p2p: Serialize cmpctblock at most once in NewPoWValidBlock
ClosedPublic
Actions

Authored by PiRK on Nov 13 2023, 07:32.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC1cde406b7431: p2p: Serialize cmpctblock at most once in NewPoWValidBlock

Summary

Instead of serializing for each peer, serialize at most once and copy the raw data for each peer.

This is a backport of core#23880

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 13 2023, 07:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 13 2023, 07:32

PiRK requested review of this revision.Nov 13 2023, 07:32

teamcity edited the summary of this revision. (Show Details)Nov 13 2023, 07:32

Harbormaster completed remote builds in B25598: Diff 43048.Nov 13 2023, 07:54

TIL

src/net_processing.cpp
2402 ↗	(On Diff #43048)	Unrelated: this should be a BlockHash

This revision is now accepted and ready to land.Nov 13 2023, 13:01

Closed by commit rABC1cde406b7431: p2p: Serialize cmpctblock at most once in NewPoWValidBlock (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyNov 13 2023, 16:08

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC1cde406b7431: p2p: Serialize cmpctblock at most once in NewPoWValidBlock.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

15 lines

Diff 43065

View Options

p2p: Serialize cmpctblock at most once in NewPoWValidBlockClosedPublicActions