Page MenuHomePhabricator
Differential D14819

[e.cash] Add FAQ to staking page
ClosedPublic
Actions

Authored by Mengerian on Nov 19 2023, 15:30.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCcab8460be356: [e.cash] Add FAQ to staking page
Summary

Start with a couple questions that people have been asking.
Can add more as new questions arise

Test Plan

Ran it locally
Read though the questions and answers to make sure they make sense

Diff Detail

Repository
rABC Bitcoin ABC
Branch
e.cash-staking-faq
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25678
Build 50936: Build Diff
Build 50935: arc lint + arc unit

Event Timeline

Mengerian created this revision.Nov 19 2023, 15:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 19 2023, 15:30
Mengerian requested review of this revision.Nov 19 2023, 15:30
Harbormaster completed remote builds in B25676: Diff 43169.Nov 19 2023, 15:30
Mengerian updated this revision to Diff 43170.Nov 19 2023, 15:38

Capitalize words in heading

Harbormaster completed remote builds in B25677: Diff 43170.Nov 19 2023, 15:38
Mengerian updated this revision to Diff 43171.Nov 19 2023, 15:42

Rebase

Harbormaster completed remote builds in B25678: Diff 43171.Nov 19 2023, 15:42
Fabien added a comment.Nov 19 2023, 19:26

@bot preview-e.cash

teamcity awarded a token.Nov 19 2023, 19:26

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41821 for the next 60 minutes.

Fabien requested changes to this revision.Nov 19 2023, 19:40

Minor wording/simplification suggestions

web/e.cash/pages/staking.js
92–98
107
This revision now requires changes to proceed.Nov 19 2023, 19:40
Mengerian updated this revision to Diff 43175.Nov 19 2023, 22:10

Tweak wording based on review comments

Harbormaster completed remote builds in B25680: Diff 43175.Nov 19 2023, 22:10
Mengerian marked 2 inline comments as done.Nov 19 2023, 22:11
Mengerian added inline comments.
web/e.cash/pages/staking.js
107

I used "directly proportional" since I think that's a more technically accurate way to describe it: https://en.wikipedia.org/wiki/Proportionality_(mathematics)

Let me know if you still prefer "solely proportional"

Fabien accepted this revision.Nov 20 2023, 08:12

sounds good

This revision is now accepted and ready to land.Nov 20 2023, 08:12
Closed by commit rABCcab8460be356: [e.cash] Add FAQ to staking page (authored by Mengerian). · Explain WhyNov 20 2023, 15:48
This revision was automatically updated to reflect the committed changes.
Mengerian marked an inline comment as done.
Mengerian added a commit: rABCcab8460be356: [e.cash] Add FAQ to staking page.

Revision Contents
Changeset List

PathSize
web/
e.cash/
pages/
23 lines

Diff 43171

View Options

web/e.cash/pages/staking.js

Loading...