Differential D14830

[avalanche] Fix a use after free bug in the peer manager unit tests
ClosedPublic
Actions

Authored by Fabien on Nov 21 2023, 15:34.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC6a9d2e9baa02: [avalanche] Fix a use after free bug in the peer manager unit tests

Summary

D14825 introduced a new facility to clear the peer set in the tests, however the loop doesn't account for the rehash occuring by the erasal.

Test Plan

With ASAN:

ninja check-avalanche-peermanager_tests

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_race_peermanager_tests

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25695
Build 50970: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 50969: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 21 2023, 15:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 21 2023, 15:34

Fabien requested review of this revision.Nov 21 2023, 15:34

@bot build-asan

teamcity awarded a token.Nov 21 2023, 15:34

PiRK accepted this revision.Nov 21 2023, 16:17

This revision is now accepted and ready to land.Nov 21 2023, 16:17

Harbormaster completed remote builds in B25695: Diff 43200.Nov 21 2023, 16:25

Closed by commit rABC6a9d2e9baa02: [avalanche] Fix a use after free bug in the peer manager unit tests (authored by Fabien). · Explain WhyNov 21 2023, 19:19

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC6a9d2e9baa02: [avalanche] Fix a use after free bug in the peer manager unit tests.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

peermanager_tests.cpp

6 lines

Diff 43200

View Options

src/avalanche/test/peermanager_tests.cpp

[avalanche] Fix a use after free bug in the peer manager unit testsClosedPublicActions