Differential D14868

[seeder] Fix the net magic not being found
ClosedPublic
Actions

Authored by Fabien on Nov 28 2023, 15:42.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC0fcfa5869722: [seeder] Fix the net magic not being found

Summary

Since D14689 the CDataStream content is always of type uint8_t. The seeder macros to check for the net magic casts to char, which causes a mismatch.

Test Plan

Checked live on a seeder that it fixes the issue.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

seeder_char_uint8

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25759
Build 51098: Build Diff	build-without-wallet · build-clang · build-clang-tidy · lint-circular-dependencies · build-debug · build-diff
Build 51097: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 28 2023, 15:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 28 2023, 15:42

Fabien requested review of this revision.Nov 28 2023, 15:42

PiRK accepted this revision.Nov 28 2023, 15:52

This revision is now accepted and ready to land.Nov 28 2023, 15:52

Harbormaster completed remote builds in B25759: Diff 43292.Nov 28 2023, 16:03

Closed by commit rABC0fcfa5869722: [seeder] Fix the net magic not being found (authored by Fabien). · Explain WhyNov 28 2023, 16:30

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC0fcfa5869722: [seeder] Fix the net magic not being found.

PiRK mentioned this in D14856: [seeder] handle CAddress-without-nTime logic.Nov 28 2023, 17:05

Revision Contents
Changeset List

Path

Size

src/

seeder/

util.h

4 lines

Diff 43292

View Options

[seeder] Fix the net magic not being foundClosedPublicActions