Differential D14952

[electrum] add more typehints for blockchain related functions
ClosedPublic
Actions

Authored by PiRK on Dec 8 2023, 10:18.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCce73331041c0: [electrum] add more typehints for blockchain related functions

Summary

And refactor can_connect -> get_connecting_chain because it return a Blockchain that is used in network.py (same rationale as get_chain_for_header refactoring in D14950)

Depends on D14951

Test Plan

python test_runner.py
pytest electrumabc/tests/regtest

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cleanup_network

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25892
Build 51360: Build Diff	electrum-tests
Build 51359: arc lint + arc unit

Event Timeline

PiRK created this revision.Dec 8 2023, 10:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 8 2023, 10:18

PiRK requested review of this revision.Dec 8 2023, 10:18

Harbormaster completed remote builds in B25892: Diff 43508.Dec 8 2023, 10:19

typo

Harbormaster completed remote builds in B25893: Diff 43509.Dec 8 2023, 10:22

bytesofman accepted this revision.Dec 8 2023, 13:27

bytesofman added a subscriber: bytesofman.

bytesofman added inline comments.

electrum/electrumabc/blockchain.py
230 ↗	(On Diff #43509)	Is this still true?

This revision is now accepted and ready to land.Dec 8 2023, 13:27

PiRK added a child revision: D14955: [electrum] start adding typehints and documentation to network.py.Dec 8 2023, 13:42

PiRK added inline comments.Dec 8 2023, 13:44

electrum/electrumabc/blockchain.py
230 ↗	(On Diff #43509)	Yes, it hasn't diverged much: https://github.com/spesmilo/electrumx/blob/master/electrumx/lib/merkle.py#L94

Closed by commit rABCce73331041c0: [electrum] add more typehints for blockchain related functions (authored by PiRK). · Explain WhyDec 8 2023, 13:59

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCce73331041c0: [electrum] add more typehints for blockchain related functions.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc/

blockchain.py

31 lines

network.py

15 lines

Diff 43508

View Options

electrum/electrumabc/blockchain.py