Page MenuHomePhabricator
Differential D14955

[electrum] start adding typehints and documentation to network.py
ClosedPublic
Actions

Authored by PiRK on Dec 8 2023, 13:42.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC325a9c1bfe27: [electrum] start adding typehints and documentation to network.py
Summary

Also rename the type alias Request to interfaceRequest in interface.py, so we can add a NetworkRequest type alias in network.py. The two are similar but different.

Depends on D14952

Test Plan
python test_runner.py
pytest electrumabc/tests/regtest

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cleanup_network
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25898
Build 51371: Build Diffelectrum-tests
Build 51370: arc lint + arc unit

Event Timeline

PiRK created this revision.Dec 8 2023, 13:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 8 2023, 13:42
PiRK requested review of this revision.Dec 8 2023, 13:42
bytesofman requested changes to this revision.Dec 8 2023, 13:45
bytesofman added a subscriber: bytesofman.
bytesofman added inline comments.
electrum/electrumabc/network.py
771 ↗(On Diff #43516)

left over from debugging?

This revision now requires changes to proceed.Dec 8 2023, 13:45
Harbormaster completed remote builds in B25897: Diff 43516.Dec 8 2023, 13:52
PiRK updated this revision to Diff 43519.Dec 8 2023, 14:01

remove debugging print, improve the docstring for requested chunks

bytesofman accepted this revision.Dec 8 2023, 14:11
This revision is now accepted and ready to land.Dec 8 2023, 14:11
Harbormaster completed remote builds in B25898: Diff 43519.Dec 8 2023, 14:28
Closed by commit rABC325a9c1bfe27: [electrum] start adding typehints and documentation to network.py (authored by PiRK). · Explain WhyDec 8 2023, 14:31
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC325a9c1bfe27: [electrum] start adding typehints and documentation to network.py.

Revision Contents
Changeset List

PathSize
electrum/
electrumabc/
7 lines
66 lines

Diff 43519

View Options

electrum/electrumabc/interface.py

Loading...
View Options

electrum/electrumabc/network.py

Loading...