Page MenuHomePhabricator

[electrum] add more docstrings and typehint to network and interface code
ClosedPublic

Authored by PiRK on Dec 11 2023, 16:51.

Details

Summary

This is an attempt at documenting the current behavior the network's state machine.

The fixme comment points to the codepath that causes the reorg issue in the tests in D14944.

Test Plan

Mostly proof-reading.

Check also that we didn't accidentaly break anything:

python test_runner.py
pytest electrumabc/tests/regtest

Diff Detail

Event Timeline

PiRK published this revision for review.Dec 12 2023, 09:44
PiRK edited the test plan for this revision. (Show Details)
Fabien added a subscriber: Fabien.
Fabien added inline comments.
electrum/electrumabc/interface.py
429
This revision is now accepted and ready to land.Dec 12 2023, 14:14
This revision was landed with ongoing or failed builds.Dec 12 2023, 14:54
This revision was automatically updated to reflect the committed changes.