Page MenuHomePhabricator

[Cashtab] Use only one app.css for webapp and extension
ClosedPublic

Authored by bytesofman on Dec 12 2023, 22:51.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCcabb4f01c489: [Cashtab] Use only one app.css for webapp and extension
Summary

Extend use of the REACT_APP_BUILD_ENV variable to deprecate maintaining two app.css files.

Test Plan

npm run extension, open extension and confirm the min-width and min-height css props are there

Diff Detail

Repository
rABC Bitcoin ABC
Branch
extension-build-script-env
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25950
Build 51475: Build Diffcashtab-tests
Build 51474: arc lint + arc unit

Event Timeline

cashtab/extension/src/components/App.js
556 ↗(On Diff #43594)

doesn't really need to be gated since we are still using separate App.js files. But, this is how it will be gated when this is merged in a later diff.

This revision is now accepted and ready to land.Dec 13 2023, 10:22