Differential D15013

[electrum] disable generate key button in the delegation editor for non-HD and watch-only wallets
ClosedPublic
Actions

Authored by PiRK on Dec 20 2023, 09:45.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCf5538a1a4ca7: [electrum] disable generate key button in the delegation editor for non-HD and…

Summary

No need to show a live button that does nothing. To generate a key, the wallet must be a HD wallet and have access to the xpriv key.
Add a tooltip to explain why the button is grey and unresponsive.

Test Plan

Open the delegation editor with various types of wallets. Check that the button can only be used if the wallet can generate keys.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

electrum_non_hd_aux_keys

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26007
Build 51588: Build Diff	electrum-tests
Build 51587: arc lint + arc unit

Event Timeline

PiRK created this revision.Dec 20 2023, 09:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 20 2023, 09:45

PiRK requested review of this revision.Dec 20 2023, 09:45

Harbormaster completed remote builds in B26007: Diff 43685.Dec 20 2023, 09:46

bytesofman accepted this revision.Dec 20 2023, 17:17

This revision is now accepted and ready to land.Dec 20 2023, 17:17

Closed by commit rABCf5538a1a4ca7: [electrum] disable generate key button in the delegation editor for non-HD and… (authored by PiRK). · Explain WhyDec 21 2023, 06:59

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCf5538a1a4ca7: [electrum] disable generate key button in the delegation editor for non-HD and….

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc_gui/

qt/

avalanche/

delegation_editor.py

6 lines

Diff 43685

View Options

electrum/electrumabc_gui/qt/avalanche/delegation_editor.py

[electrum] disable generate key button in the delegation editor for non-HD and watch-only walletsClosedPublicActions