Page MenuHomePhabricator

[Cashtab] Remove google analytics call from extension
ClosedPublic

Authored by bytesofman on Jan 1 2024, 21:58.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCada7b16bf84e: [Cashtab] Remove google analytics call from extension
Summary

Extension at manifest v3 is rejected from Chrome store due to lingering calls to google analytics. Code was refactored so the calls were not used in the extension, but that is insufficient -- the code must not exist in the repo.

meta tags and link info not associated with the extension is also moved to the "webapp-only" conditionally-rendered section in index.html

Test Plan

npm run extension, navigate to extension/dist/static/js/main.*.js, ctrl+f 'analytics' and only 1 match, not in a link.
npm run build, navigate to cashtab/build/static/js/main.*.js, ctrl+f 'analytics', 8 matches including links

Diff Detail

Repository
rABC Bitcoin ABC
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26086
Build 51745: Build Diffcashtab-tests
Build 51744: arc lint + arc unit

Event Timeline

remove line breaks, simplify

bytesofman published this revision for review.Jan 1 2024, 22:15
Fabien added inline comments.
cashtab/src/utils/GoogleAnalytics.js
95 ↗(On Diff #43807)

Why do you still need the GoogleAnalytics ?

bytesofman marked an inline comment as done.

remove GoogleAnalytics export

cashtab/src/utils/GoogleAnalytics.js
95 ↗(On Diff #43807)

good point, it is not used anywhere in the app as an export. removed.

This revision is now accepted and ready to land.Jan 2 2024, 20:27