Paths

Table of Contentst

Differential D15055

[Cashtab] Use new sendXec function to register aliases
ClosedPublic
Actions

Authored by bytesofman on Jan 1 2024, 23:22.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCd8783013f4a2: [Cashtab] Use new sendXec function to register aliases

Summary

Stop using the legacy dependent registerNewAlias function and instead use the new sendXec function

After this is in, will have a separate diff to deprecate legacy transaction building functions that are no longer used.

Test Plan

npm test, change aliasEnabled flag to true, npm start, register an alias, confirm it is live on test server

Diff Detail

Repository

rABC Bitcoin ABC

Branch

better-alias-txs

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26090
Build 51753: Build Diff	cashtab-tests
Build 51752: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 1 2024, 23:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 1 2024, 23:22

bytesofman requested review of this revision.Jan 1 2024, 23:22

remove debug logs

Harbormaster completed remote builds in B26089: Diff 43808.Jan 1 2024, 23:25

Harbormaster completed remote builds in B26090: Diff 43809.Jan 1 2024, 23:27

Fabien accepted this revision.Jan 2 2024, 08:54

This revision is now accepted and ready to land.Jan 2 2024, 08:54

Closed by commit rABCd8783013f4a2: [Cashtab] Use new sendXec function to register aliases (authored by bytesofman). · Explain WhyJan 2 2024, 17:07

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCd8783013f4a2: [Cashtab] Use new sendXec function to register aliases.

Revision Contents
Changeset List

Path

Size

cashtab/

src/

components/

Alias/

Alias.js

23 lines

Diff 43809

View Options

cashtab/src/components/Alias/Alias.js

[Cashtab] Use new sendXec function to register aliasesClosedPublicActions