Page MenuHomePhabricator

[ecash bip21] Make empty OP_RETURN out of spec
ClosedPublic

Authored by bytesofman on Jan 2 2024, 18:40.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCc78b5ff801c4: [ecash bip21] Make empty OP_RETURN out of spec
Summary

I can't think of a good reason to include an empty OP_RETURN output. I could though imagine it happening by accident if someone is generating bip21 params.

Make this out of spec so implementer validation can catch it.

Test Plan

Review summary, attempt to think of counterexample good reason for empty opreturn in params

Diff Detail

Repository
rABC Bitcoin ABC
Branch
bip21mod
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26101
Build 51775: Build Diff
Build 51774: arc lint + arc unit