Page MenuHomePhabricator

[Cashtab] Generate targetOutputs for SLP genesis tx
ClosedPublic

Authored by bytesofman on Jan 2 2024, 19:34.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC03278942b8c3: [Cashtab] Generate targetOutputs for SLP genesis tx
Summary

Add new function to generate a targetOutput for an SLP genesis tx.

This diff adds and unit tests the function. Function is not implemented.

Goal is to deprecate generateGenesisOpReturn and generateTokenTxOutput functions in cashMethods.js

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
slp-test-mods
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26107
Build 51787: Build Diffcashtab-tests
Build 51786: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Jan 2 2024, 20:40
Fabien added a subscriber: Fabien.
Fabien added inline comments.
cashtab/src/opreturn/index.js
163 ↗(On Diff #43825)

v0 ? you mean v1 ?

168 ↗(On Diff #43825)

You may want a new slpv1/ subdir to put these functions

This revision now requires changes to proceed.Jan 2 2024, 20:40
bytesofman marked 2 inline comments as done.

move slp function to new slpv1 dir, correct version error

cashtab/src/opreturn/index.js
163 ↗(On Diff #43825)

indeed

168 ↗(On Diff #43825)

good point will be a bunch of these

This revision is now accepted and ready to land.Jan 3 2024, 09:02