Page MenuHomePhabricator
Differential D15060

[Cashtab] Generate targetOutputs for SLP genesis tx
ClosedPublic
Actions

Authored by bytesofman on Jan 2 2024, 19:34.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC03278942b8c3: [Cashtab] Generate targetOutputs for SLP genesis tx
Summary

Add new function to generate a targetOutput for an SLP genesis tx.

This diff adds and unit tests the function. Function is not implemented.

Goal is to deprecate generateGenesisOpReturn and generateTokenTxOutput functions in cashMethods.js

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
slp-test-mods
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26108
Build 51789: Build Diffcashtab-tests
Build 51788: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 2 2024, 19:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 2 2024, 19:34
bytesofman requested review of this revision.Jan 2 2024, 19:34
Harbormaster completed remote builds in B26103: Diff 43825.Jan 2 2024, 19:37
Fabien requested changes to this revision.Jan 2 2024, 20:40
Fabien added a subscriber: Fabien.
Fabien added inline comments.
cashtab/src/opreturn/index.js
163 ↗(On Diff #43825)

v0 ? you mean v1 ?

168 ↗(On Diff #43825)

You may want a new slpv1/ subdir to put these functions

This revision now requires changes to proceed.Jan 2 2024, 20:40
bytesofman updated this revision to Diff 43832.Jan 2 2024, 23:22
bytesofman marked 2 inline comments as done.

move slp function to new slpv1 dir, correct version error

cashtab/src/opreturn/index.js
163 ↗(On Diff #43825)

indeed

168 ↗(On Diff #43825)

good point will be a bunch of these

bytesofman updated this revision to Diff 43833.Jan 2 2024, 23:23

copypasta fix

Harbormaster completed remote builds in B26107: Diff 43832.Jan 2 2024, 23:25
Harbormaster completed remote builds in B26108: Diff 43833.
Fabien accepted this revision.Jan 3 2024, 09:02
This revision is now accepted and ready to land.Jan 3 2024, 09:02
Closed by commit rABC03278942b8c3: [Cashtab] Generate targetOutputs for SLP genesis tx (authored by bytesofman). · Explain WhyJan 3 2024, 14:27
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC03278942b8c3: [Cashtab] Generate targetOutputs for SLP genesis tx.

Revision Contents
Changeset List

PathSize
cashtab/
src/
slpv1/
__tests__/
32 lines
fixtures/
81 lines
35 lines

Diff 43833

View Options

cashtab/src/slpv1/__tests__/index.test.js

Loading...
View Options

cashtab/src/slpv1/fixtures/vectors.js

Loading...
View Options

cashtab/src/slpv1/index.js

Loading...