Page MenuHomePhabricator

[Cashtab] Deprecate legacy transaction functions
ClosedPublic

Authored by bytesofman on Jan 3 2024, 14:13.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCa2850e4c99a4: [Cashtab] Deprecate legacy transaction functions
Summary

These functions have been replaced by implemented functions in transactions/index.js

The remaining functions in utils/transactions.js are still pending some additional SLP helper functions

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
deprecate-legacy-sendxec-fn
Lint
Lint Errors
SeverityLocationCodeMessage
Errorcashtab/src/utils/transactions.js:3ESLINTno-unused-vars
Errorcashtab/src/utils/transactions.js:4ESLINTno-unused-vars
Errorcashtab/src/utils/transactions.js:8ESLINTno-unused-vars
Errorcashtab/src/utils/transactions.js:9ESLINTno-unused-vars
Errorcashtab/src/utils/transactions.js:10ESLINTno-unused-vars
Errorcashtab/src/utils/transactions.js:11ESLINTno-unused-vars
Errorcashtab/src/utils/transactions.js:16ESLINTno-unused-vars
Errorcashtab/src/utils/transactions.js:17ESLINTno-unused-vars
Unit
No Test Coverage
Build Status
Buildable 26118
Build 51809: Build Diffcashtab-tests
Build 51808: arc lint + arc unit

Event Timeline

Tail of the build log:

/work/cashtab /work/abc-ci-builds/cashtab-tests
npm WARN deprecated w3c-hr-time@1.0.2: Use your platform's native performance.now() and performance.timeOrigin.
npm WARN deprecated sourcemap-codec@1.4.8: Please use @jridgewell/sourcemap-codec instead
npm WARN deprecated rollup-plugin-terser@7.0.2: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-terser
npm WARN deprecated stable@0.1.8: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility
npm WARN deprecated text-encoding@0.6.4: no longer maintained
npm WARN deprecated ts-custom-error@2.2.2: npm package tarball contains useless codeclimate-reporter binary, please update to version 3.1.1. See https://github.com/adriengibrat/ts-custom-error/issues/32

added 1730 packages, and audited 1731 packages in 20s

236 packages are looking for funding
  run `npm fund` for details

5 moderate severity vulnerabilities

To address all issues possible (including breaking changes), run:
  npm audit fix --force

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.

> cashtab@1.0.0 build
> node scripts/build.js

Creating an optimized production build...
Failed to compile.

[eslint] 
src/utils/transactions.js
  Line 3:5:   'generateTxInput' is defined but never used                 no-unused-vars
  Line 4:5:   'generateTxOutput' is defined but never used                no-unused-vars
  Line 8:5:   'getChangeAddressFromInputUtxos' is defined but never used  no-unused-vars
  Line 9:5:   'toHash160' is defined but never used                       no-unused-vars
  Line 10:5:  'generateAliasOpReturnScript' is defined but never used     no-unused-vars
  Line 11:5:  'fromSatoshisToXec' is defined but never used               no-unused-vars
  Line 16:8:  'aliasSettings' is defined but never used                   no-unused-vars
  Line 17:8:  'BigNumber' is defined but never used                       no-unused-vars

Search for the keywords to learn more about each error.


Build cashtab-tests failed with exit code 1

Tail of the build log:

/work/cashtab /work/abc-ci-builds/cashtab-tests
npm WARN deprecated w3c-hr-time@1.0.2: Use your platform's native performance.now() and performance.timeOrigin.
npm WARN deprecated sourcemap-codec@1.4.8: Please use @jridgewell/sourcemap-codec instead
npm WARN deprecated rollup-plugin-terser@7.0.2: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-terser
npm WARN deprecated stable@0.1.8: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility
npm WARN deprecated text-encoding@0.6.4: no longer maintained
npm WARN deprecated ts-custom-error@2.2.2: npm package tarball contains useless codeclimate-reporter binary, please update to version 3.1.1. See https://github.com/adriengibrat/ts-custom-error/issues/32

added 1730 packages, and audited 1731 packages in 20s

236 packages are looking for funding
  run `npm fund` for details

5 moderate severity vulnerabilities

To address all issues possible (including breaking changes), run:
  npm audit fix --force

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.

> cashtab@1.0.0 build
> node scripts/build.js

Creating an optimized production build...
Failed to compile.

[eslint] 
src/utils/transactions.js
  Line 3:5:   'generateTxInput' is defined but never used                 no-unused-vars
  Line 4:5:   'generateTxOutput' is defined but never used                no-unused-vars
  Line 8:5:   'getChangeAddressFromInputUtxos' is defined but never used  no-unused-vars
  Line 9:5:   'toHash160' is defined but never used                       no-unused-vars
  Line 10:5:  'generateAliasOpReturnScript' is defined but never used     no-unused-vars
  Line 11:5:  'fromSatoshisToXec' is defined but never used               no-unused-vars
  Line 16:8:  'aliasSettings' is defined but never used                   no-unused-vars
  Line 17:8:  'BigNumber' is defined but never used                       no-unused-vars

Search for the keywords to learn more about each error.


Build cashtab-tests failed with exit code 1

CI test failure here related to failure to remove unused dependencies from affected files. Build succeeded after lint fixes.

PiRK added a subscriber: PiRK.

@bot cashtab-tests

This revision is now accepted and ready to land.Jan 3 2024, 16:05