Page MenuHomePhabricator

[Cashtab] Update webpack to support cjs
ClosedPublic

Authored by bytesofman on Jan 4 2024, 04:45.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCa712112bc1d6: [Cashtab] Update webpack to support cjs
Summary

Known issue with create-react-app. As more dependencies use these files, will need this support.

Main issue now is that the latest chronik-client won't work, since it uses the latest version of axios, which uses cjs files.

Cashtab will work with the latest version of chronik-client with this webpack config.

I can wait and add them together so there is a test plan, but imo it makes sense to keep this as an isolated change.

This is more or less a backport of (still unmerged) https://github.com/facebook/create-react-app/pull/12021

Cashtab was initially a create-react-app app, but has been ejected and customized to support crypto dependencies.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cashtab-update-reactapp-config
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26135
Build 51843: Build Diffcashtab-tests
Build 51842: arc lint + arc unit

Event Timeline

bytesofman published this revision for review.Jan 4 2024, 04:48
bytesofman edited the summary of this revision. (Show Details)
Fabien added a subscriber: Fabien.

No idea what this does

This revision is now accepted and ready to land.Jan 4 2024, 16:25
This revision was automatically updated to reflect the committed changes.