Page MenuHomePhabricator
Differential D15099

[Chronik] Add `MempoolTokens` to index mempool token txs
ClosedPublic
Actions

Authored by tobias_ruck on Jan 5 2024, 17:27.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC9fe11d18aec3: [Chronik] Add `MempoolTokens` to index mempool token txs
Summary

Parses, colors, validates and indexes mempool txs as SLP/ALP txs.

In fetch_tx_spent_tokens, bulk-query ops are used wherever possible. It is exposed so we can use it in the indexer later, too.

Test Plan

cargo test -p chronik-db test_mempool_tokens

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik-slp-mempool
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26183
Build 51938: Build Diffbuild-chronik · chronik-client-integration-tests
Build 51937: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Jan 5 2024, 17:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 5 2024, 17:27
tobias_ruck requested review of this revision.Jan 5 2024, 17:27
tobias_ruck updated this revision to Diff 43946.

remove dbg! macros

Harbormaster completed remote builds in B26183: Diff 43945.Jan 5 2024, 17:46
Harbormaster completed remote builds in B26184: Diff 43946.
Fabien requested changes to this revision.Jan 8 2024, 09:45
Fabien added inline comments.
chronik/chronik-db/src/mem/tokens.rs
38 ↗(On Diff #43946)

Please add the word token somewhere in this message, otherwise it can be understood as if the mempool was corrupted

89 ↗(On Diff #43946)

Since this is expected to not fail as the genesis should be in a block already, should you have some error in the else case to give feedback to the user?

164 ↗(On Diff #43946)

What happens if the tx is in the mempool but the vout doesn't exist ?

195 ↗(On Diff #43946)

Please comment: "Not a token spendable output"

777 ↗(On Diff #43946)
804 ↗(On Diff #43946)

Can you remove txid(10) and check the input is not found on txid(11) instead ? You get more coverage

This revision now requires changes to proceed.Jan 8 2024, 09:45
tobias_ruck added inline comments.Jan 8 2024, 10:07
chronik/chronik-db/src/mem/tokens.rs
89 ↗(On Diff #43946)

The error will be "Missing MINT Vault"; I think this should be enough in practice

164 ↗(On Diff #43946)

token_tx.outputs.get(out_idx) => None already covers that. And for non-token txs, bitcoind will ensure the output exists

tobias_ruck updated this revision to Diff 44076.Jan 11 2024, 23:09

mention "token" in error messages; add explanatory comments; fix typo; test tx 10 too

tobias_ruck added inline comments.Jan 11 2024, 23:11
chronik/chronik-db/src/mem/tokens.rs
804 ↗(On Diff #43946)

Not sure why exactly; the mempool expects txs to be removed in reverse-topological order and 11 depends on 10, so it'll just sperg

Harbormaster completed remote builds in B26276: Diff 44076.Jan 11 2024, 23:14
teamcity added a comment.Jan 11 2024, 23:14
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
tobias_ruck updated this revision to Diff 44078.Jan 11 2024, 23:38

rerun CI

Harbormaster completed remote builds in B26278: Diff 44078.Jan 11 2024, 23:40
teamcity added a comment.Jan 11 2024, 23:40
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Fabien requested changes to this revision.Jan 12 2024, 13:55

Please rebase on master for the tests to run

This revision now requires changes to proceed.Jan 12 2024, 13:55
tobias_ruck updated this revision to Diff 44113.Jan 12 2024, 19:56

rebase on master

Harbormaster completed remote builds in B26303: Diff 44113.Jan 12 2024, 20:18
tobias_ruck updated this revision to Diff 44129.Jan 12 2024, 23:57

add long SLP V2 rant

tobias_ruck updated this revision to Diff 44130.Jan 12 2024, 23:57

diff unsaved formatting

Harbormaster completed remote builds in B26319: Diff 44129.Jan 13 2024, 00:16
Harbormaster completed remote builds in B26320: Diff 44130.Jan 13 2024, 00:18
tobias_ruck updated this revision to Diff 44163.Jan 15 2024, 00:00

fix bug when adding uncolored txs that burn tokens to the mempool

Harbormaster completed remote builds in B26346: Diff 44163.Jan 15 2024, 00:21
Fabien accepted this revision.Jan 15 2024, 11:04
This revision is now accepted and ready to land.Jan 15 2024, 11:04
Closed by commit rABC9fe11d18aec3: [Chronik] Add `MempoolTokens` to index mempool token txs (authored by tobias_ruck). · Explain WhyJan 15 2024, 11:58
This revision was automatically updated to reflect the committed changes.
tobias_ruck added a commit: rABC9fe11d18aec3: [Chronik] Add `MempoolTokens` to index mempool token txs.

Revision Contents
Changeset List

PathSize
chronik/
bitcoinsuite-slp/
src/
6 lines
2 lines
chronik-db/
src/
io/
token/
18 lines
2 lines
tests/
2 lines
mem/
2 lines
816 lines

Diff 43945

View Options

chronik/bitcoinsuite-slp/src/test_helpers.rs

Loading...
View Options

chronik/bitcoinsuite-slp/src/verify.rs

Loading...
View Options

chronik/chronik-db/src/io/token/io.rs

Loading...
View Options

chronik/chronik-db/src/io/token/mod.rs

Loading...
View Options

chronik/chronik-db/src/io/token/tests/mod.rs

Loading...
View Options

chronik/chronik-db/src/mem/mod.rs

Loading...
View Options

chronik/chronik-db/src/mem/tokens.rs

Loading...