Paths

Table of Contentst

Differential D15122

[Cashtab] Better component organization and routing for etokens
ClosedPublic
Actions

Authored by bytesofman on Jan 9 2024, 23:50.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC998ef2d45c0c: [Cashtab] Better component organization and routing for etokens

Summary

Some cleanup after moving eTokens out of Home and onto their own screen. We shouldn't have src/components/Etokens and src/components/Tokens folders. Keep all the relevant components under src/components/Etokens

Tokens.js is confusingly named. This should be CreateToken.js, and its route should also be create-token.

Test Plan

npm test

npm start, check tokens page, click create a token and note route

Diff Detail

Repository

rABC Bitcoin ABC

Branch

deprecate-unused-component

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26233
Build 52038: Build Diff	cashtab-tests
Build 52037: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 9 2024, 23:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 9 2024, 23:50

bytesofman published this revision for review.Jan 9 2024, 23:50

bytesofman edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B26233: Diff 44009.Jan 9 2024, 23:52

Tested all ok. Gonna be a hellish rebase for D15079 though.

This revision is now accepted and ready to land.Jan 10 2024, 00:44

Closed by commit rABC998ef2d45c0c: [Cashtab] Better component organization and routing for etokens (authored by bytesofman). · Explain WhyJan 10 2024, 14:13

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC998ef2d45c0c: [Cashtab] Better component organization and routing for etokens.

emack mentioned this in D15079: [Cashtab] Ignore function for tokens - pt 1 of 2.Jan 12 2024, 00:07

Revision Contents
Changeset List

Path

Size

cashtab/

src/

components/

App.js

6 lines

	Etokens/
	Tokens/

	CreateToken.js
	Tokens.js

10 lines

CreateTokenForm.js

832 lines

TokenIcon.js

35 lines

__tests__/

CreateTokenForm.test.js

4 lines

__snapshots__/

CreateTokenForm.test.js.snap

355 lines

Etokens/

Etokens.js

4 lines

	Etokens/
	Home/

TokenList.js

31 lines

TokenListItem.js

2 lines

Home/

TokenList.js

TokenListItem.js

Tx.js

2 lines

Send/

SendToken.js

2 lines

Tokens/

CreateTokenForm.js

TokenIcon.js

Tokens.js

__tests__/

CreateTokenForm.test.js

__snapshots__/

CreateTokenForm.test.js.snap

Diff 44009

View Options

cashtab/src/components/App.js

View Options

cashtab/src/components/Etokens/CreateToken.js

View Options

cashtab/src/components/Etokens/CreateTokenForm.js

View Options

cashtab/src/components/Etokens/Etokens.js

View Options

cashtab/src/components/Etokens/TokenIcon.js

View Options

cashtab/src/components/Etokens/TokenList.js

View Options

cashtab/src/components/Etokens/TokenListItem.js

View Options

cashtab/src/components/Etokens/tests/CreateTokenForm.test.js

View Options

cashtab/src/components/Etokens/tests/snapshots/CreateTokenForm.test.js.snap

View Options

cashtab/src/components/Home/TokenList.js

View Options

cashtab/src/components/Home/TokenListItem.js

View Options

cashtab/src/components/Home/Tx.js

View Options

cashtab/src/components/Send/SendToken.js

View Options

cashtab/src/components/Tokens/CreateTokenForm.js

View Options

cashtab/src/components/Tokens/TokenIcon.js

View Options

cashtab/src/components/Tokens/Tokens.js

View Options

cashtab/src/components/Tokens/tests/CreateTokenForm.test.js

View Options

cashtab/src/components/Tokens/tests/snapshots/CreateTokenForm.test.js.snap

[Cashtab] Better component organization and routing for etokensClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 44009

cashtab/src/components/App.js

cashtab/src/components/Etokens/CreateToken.js

cashtab/src/components/Etokens/CreateTokenForm.js

cashtab/src/components/Etokens/Etokens.js

cashtab/src/components/Etokens/TokenIcon.js

cashtab/src/components/Etokens/TokenList.js

cashtab/src/components/Etokens/TokenListItem.js

cashtab/src/components/Etokens/__tests__/CreateTokenForm.test.js

cashtab/src/components/Etokens/__tests__/__snapshots__/CreateTokenForm.test.js.snap

cashtab/src/components/Home/TokenList.js

cashtab/src/components/Home/TokenListItem.js

cashtab/src/components/Home/Tx.js

cashtab/src/components/Send/SendToken.js

cashtab/src/components/Tokens/CreateTokenForm.js

cashtab/src/components/Tokens/TokenIcon.js

cashtab/src/components/Tokens/Tokens.js

cashtab/src/components/Tokens/__tests__/CreateTokenForm.test.js

cashtab/src/components/Tokens/__tests__/__snapshots__/CreateTokenForm.test.js.snap

[Cashtab] Better component organization and routing for etokens
ClosedPublic
Actions

Revision Contents
Changeset List

cashtab/src/components/Etokens/tests/CreateTokenForm.test.js

cashtab/src/components/Etokens/tests/snapshots/CreateTokenForm.test.js.snap

cashtab/src/components/Tokens/tests/CreateTokenForm.test.js

cashtab/src/components/Tokens/tests/snapshots/CreateTokenForm.test.js.snap