Page MenuHomePhabricator

[Cashtab] Stop using a function that isnt really used in SignVerify component
ClosedPublic

Authored by bytesofman on Jan 11 2024, 05:09.

Details

Summary

We don't support params in this screen so we should not be using the parseAddressForParams function. We are just passing user input there to get it back in an object at the address key.

Stop doing this.

Ref D15134 for the bigger picture here -- we need more granular info in the parseAddressForParams function to support additional bip21 parameters like opreturn

Test Plan

npm test

npm start, navigate to sign verify screen, paste a valid ecash: address in verify box and note no validation, paste an invalid address and note error msg, paste an etoken: addr and note error msg

Diff Detail

Repository
rABC Bitcoin ABC
Branch
no-parse-sig-ver
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26258
Build 52088: Build Diffcashtab-tests
Build 52087: arc lint + arc unit

Event Timeline

emack added a subscriber: emack.

Tested fine, but probably should have an alias specific validation in a separate diff to note aliases are not supported for signature verification

image.png (133×589 px, 14 KB)

This revision is now accepted and ready to land.Jan 11 2024, 07:42

rebase, error msg for aliases

This revision was landed with ongoing or failed builds.Jan 11 2024, 14:14
This revision was automatically updated to reflect the committed changes.