Various nits in sigopcount_tests.cpp and script_P2SH_tests.cpp
ClosedPublic
Actions

Authored by deadalnix on Jul 25 2018, 16:05.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING9bb5290f6289: Various nits in sigopcount_tests.cpp and script_P2SH_tests.cpp
rABC9bb5290f6289: Various nits in sigopcount_tests.cpp and script_P2SH_tests.cpp

Summary

As per title. Use BOOST_CHECK_EQUAL instead of assertions and various style nits.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

testnits

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2945
Build 3990: Bitcoin ABC Buildbot (legacy)
Build 3989: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 25 2018, 16:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 25 2018, 16:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

One more BOOST_CHECK_EQUAL

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2944: Diff 4406.Jul 25 2018, 16:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2945: Diff 4407.Jul 25 2018, 16:52

deadalnix added a child revision: D1596: Add test case for GetTransactionSigOpCount without the P2SH flags passed in..Jul 25 2018, 17:48

jasonbcox accepted this revision.Jul 25 2018, 18:35

This revision is now accepted and ready to land.Jul 25 2018, 18:35

Closed by commit rABC9bb5290f6289: Various nits in sigopcount_tests.cpp and script_P2SH_tests.cpp (authored by deadalnix). · Explain WhyJul 25 2018, 21:02

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

test/

script_P2SH_tests.cpp

8 lines

sigopcount_tests.cpp

27 lines

Diff 4407

View Options

src/test/script_P2SH_tests.cpp