Page MenuHomePhabricator
Differential D15154

[Cashtab] Improve unit test organization for isValidAlias
ClosedPublic
Actions

Authored by bytesofman on Jan 12 2024, 20:56.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCdcd0c3fe62eb: [Cashtab] Improve unit test organization for isValidAlias
Summary

Refactor isValidAlias unit tests to use vector approach

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26309
Build 52188: Build Diffcashtab-tests
Build 52187: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 12 2024, 20:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 12 2024, 20:56
Harbormaster completed remote builds in B26308: Diff 44118.Jan 12 2024, 21:01
bytesofman updated this revision to Diff 44119.Jan 12 2024, 21:02

Back out name change and only do unit test improvements here

bytesofman published this revision for review.Jan 12 2024, 21:03
bytesofman retitled this revision from [Cashtab] Improve comments, unit tests, and name for isValidAlias to [Cashtab] Improve unit test organization for isValidAlias.
bytesofman edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B26309: Diff 44119.Jan 12 2024, 21:05
bytesofman updated this revision to Diff 44120.Jan 12 2024, 21:05

update branch name

Harbormaster completed remote builds in B26310: Diff 44120.Jan 12 2024, 21:07
PiRK accepted this revision.Jan 13 2024, 10:01
This revision is now accepted and ready to land.Jan 13 2024, 10:01
Closed by commit rABCdcd0c3fe62eb: [Cashtab] Improve unit test organization for isValidAlias (authored by bytesofman). · Explain WhyJan 13 2024, 14:48
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCdcd0c3fe62eb: [Cashtab] Improve unit test organization for isValidAlias.

Revision Contents
Changeset List

PathSize
cashtab/
src/
utils/
__tests__/
39 lines
fixtures/
53 lines

Diff 44119

View Options

cashtab/src/utils/__tests__/validation.test.js

Loading...
View Options

cashtab/src/utils/fixtures/vectors.js

Loading...