[Cashtab] Create new getBalanceSats function in wallet dir
ClosedPublic
Actions

Authored by bytesofman on Jan 17 2024, 05:22.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCa1edaacb40a2: [Cashtab] Create new getBalanceSats function in wallet dir

Summary

Introduce new function getBalanceSats which gets the total balance in satoshis from an array of chronik utxos

This is part of a broader effort to reduce technical debt in Cashtab. This is step 1 of a series of diffs to combine <BalanceHeader>, <BalanceHeaderFiat>, <ZeroBalanceHeader> components into one standardized component that also shows distinction between spendable balance and total balance.

Looking to replace getWalletBalanceFromUtxos function from cashMethods. However, a number of new functions and refactors need to happen to achieve this goal.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

helpers

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26419
Build 52408: Build Diff	cashtab-tests
Build 52407: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 17 2024, 05:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 17 2024, 05:22

Harbormaster completed remote builds in B26418: Diff 44271.Jan 17 2024, 05:25

add error and nan cases

bytesofman published this revision for review.Jan 17 2024, 05:34

bytesofman edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B26419: Diff 44272.Jan 17 2024, 05:35

Let's not replicate the errors from the past. Computing the balance from a utxo set clearly belongs to the wallet, not in some kitchen sink "util" directory.

cashtab/src/utils-v2/index.js
3	Please use a newline

This revision now requires changes to proceed.Jan 17 2024, 08:41

wallet not utils-v2, line breaks in code comments

bytesofman marked an inline comment as done.Jan 17 2024, 10:39

bytesofman retitled this revision from [Cashtab] Initialize utils-v2 dir to contain refactor functions to [Cashtab] Create new getBalanceSats function in wallet dir.

bytesofman edited the summary of this revision. (Show Details)

bytesofman edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B26425: Diff 44279.Jan 17 2024, 10:42

Fabien accepted this revision.Jan 17 2024, 13:19

Fabien added inline comments.