Paginates the tx history so users can see much further back than 10 txs.
This will make the previous approach of passing in a parsed txs array into the TxHistory component redundant, but will refactor useWallet for this in a separate diff.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project
- npm test
- npm start
- pagination reflects the total txs for wallet on explorer divided by 10
- tx history results from clicking on page 4 matches the explorer
- send and receive XEC txs and ensure it is reflected in both wallets
- send and receive OP_RETURN messages and ensure it is reflected in both wallets
- send and receive eTokens and ensure it is reflected in both wallets
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- pagination
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 26429 Build 52428: Build Diff cashtab-tests Build 52427: arc lint + arc unit
Event Timeline
Comment Actions
Integrated paginated tx history retrieval to the frontend rendering logic in TxHistory.js. Also added integration tests in TxHistory.test.js.
Comment Actions
Frontend rendering integration tests fixed. Now need to resolve the issue of no incoming txs in history.
Comment Actions
Hooking the useEffect() loop to balances.totalBalance and nonSlpUtxostwo as additional dependencies so the paginated tx history will update itself when XEC or SLP txs are detected
Comment Actions
- Page numbers should appear at bottom of tx history and remain visible to user during scrolling
- perhaps need to do this diff separately and rebase -- the balance header should be fixed and remain visible as the user scrolls
| cashtab/src/components/Home/TxHistory.js | ||
|---|---|---|
| 80 ↗ | (On Diff #44411) | even with the comment I don't understand what's going on here what happens if this isn't here? |
| cashtab/src/components/Home/__tests__/TxHistory.test.js | ||
| 196 ↗ | (On Diff #44411) | You should be able to get the antd pagination button elements bc they have textContent of the page number add a test to show expected behavior of user clicks on a different page |
Comment Actions
| cashtab/src/components/Home/TxHistory.js | ||
|---|---|---|
| 80 ↗ | (On Diff #44411) | If it's not there then you'll get a runtime error saying the txs variable is defined (via the input param) but not used. Removing it involves refactoring useWallet hence leaving it here for now. |