Page MenuHomePhabricator
Differential D15201

[Cashtab] Move validation out of utils
ClosedPublic
Actions

Authored by bytesofman on Jan 18 2024, 17:46.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC96429e14317b: [Cashtab] Move validation out of utils
Summary

As part of ongoing effort to improve organization of functions in Cashtab, move validation out of the utils/ directory and into its own directory.

Update imports, move mocks, delete legacy mocks files in utils/

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
validation-out-of-utils
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26463
Build 52496: Build Diffcashtab-tests
Build 52495: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 18 2024, 17:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 18 2024, 17:46
Harbormaster completed remote builds in B26463: Diff 44329.Jan 18 2024, 17:59
bytesofman updated this revision to Diff 44330.Jan 18 2024, 18:01

move all validation mocks to validation/fixtures/mocks + delete legacy utils mocks

bytesofman published this revision for review.Jan 18 2024, 18:01
bytesofman edited the summary of this revision. (Show Details)
bytesofman edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B26464: Diff 44330.Jan 18 2024, 18:06
Fabien accepted this revision.Jan 18 2024, 20:14
This revision is now accepted and ready to land.Jan 18 2024, 20:14
Closed by commit rABC96429e14317b: [Cashtab] Move validation out of utils (authored by bytesofman). · Explain WhyJan 18 2024, 20:47
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC96429e14317b: [Cashtab] Move validation out of utils.

Revision Contents
Changeset List

PathSize
cashtab/
src/
components/
Airdrop/
2 lines
Alias/
2 lines
Common/
3 lines
Configure/
2 lines
Etokens/
2 lines
Home/
2 lines
OnBoarding/
2 lines
Send/
2 lines
2 lines
SignVerifyMsg/
2 lines
Swap/
2 lines
hooks/
2 lines
opreturn/
2 lines
transactions/
2 lines
utils/
__mocks__/
__tests__/
2 lines
fixtures/
validation/
utils/
__tests__/
index.test.js
validation.test.js
18 lines
fixtures/
__mocks__/
mocks.js
mockXecAirdropRecipients.js
14 lines
fixtures/
2 lines
index.js
validation.js
884 lines

Diff 44329

View Options

cashtab/src/components/Airdrop/Airdrop.js

Loading...
View Options

cashtab/src/components/Alias/Alias.js

Loading...
View Options

cashtab/src/components/Common/ScanQRCode.js

Loading...
View Options

cashtab/src/components/Configure/Configure.js

Loading...
View Options

cashtab/src/components/Etokens/CreateTokenForm.js

Loading...
View Options

cashtab/src/components/Home/Home.js

Loading...
View Options

cashtab/src/components/OnBoarding/OnBoarding.js

Loading...
View Options

cashtab/src/components/Send/SendToken.js

Loading...
View Options

cashtab/src/components/Send/SendXec.js

Loading...
View Options

cashtab/src/components/SignVerifyMsg/SignVerifyMsg.js

Loading...
View Options

cashtab/src/components/Swap/Swap.js

Loading...
View Options

cashtab/src/hooks/useWallet.js

Loading...
View Options

cashtab/src/opreturn/index.js

Loading...
View Options

cashtab/src/transactions/index.js

Loading...
View Options

cashtab/src/utils/__mocks__/mockXecAirdropExclusionList.js

Loading...
View Options

cashtab/src/utils/__mocks__/mockXecAirdropRecipients.js

Loading...
View Options

cashtab/src/utils/__tests__/validation.test.js

Loading...
View Options

cashtab/src/utils/cashMethods.js

Loading...
View Options

cashtab/src/utils/fixtures/vectors.js

Loading...
View Options

cashtab/src/utils/validation.js

Loading...
View Options

cashtab/src/validation/__tests__/index.test.js

Loading...
View Options

cashtab/src/validation/fixtures/mocks.js

Loading...
View Options

cashtab/src/validation/fixtures/vectors.js

Loading...
View Options

cashtab/src/validation/index.js

Loading...