Page MenuHomePhabricator
Differential D15218

[Cashtab] Deprecate all duplicated legacy implementations of toXec and toSatoshis
ClosedPublic
Actions

Authored by bytesofman on Jan 20 2024, 01:31.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCfe9f1f67bf43: [Cashtab] Deprecate all duplicated legacy implementations of toXec and…
Summary

Bad buildup of functions that do basically the same thing. Get rid of it.

Depends on D15217

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
deprecate-old-helpers
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26520
Build 52610: Build Diffcashtab-tests
Build 52609: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 20 2024, 01:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 20 2024, 01:31
Harbormaster completed remote builds in B26506: Diff 44381.Jan 20 2024, 01:34
bytesofman published this revision for review.Jan 20 2024, 01:36
emack requested changes to this revision.Jan 20 2024, 11:48
emack added a subscriber: emack.
emack added inline comments.
cashtab/src/validation/index.js
427 ↗(On Diff #44381)

Further above in __mocks__/sendBCH.js the appConfig.dustSats param value is fed through parseInt() before passed to toXec(). Should this be standardized across the diff for consistency?

This revision now requires changes to proceed.Jan 20 2024, 11:48
bytesofman updated this revision to Diff 44396.Jan 20 2024, 14:28

rebase, remove unneeded parseInts

Harbormaster completed remote builds in B26515: Diff 44396.Jan 20 2024, 14:56
emack accepted this revision.Jan 20 2024, 22:27
This revision is now accepted and ready to land.Jan 20 2024, 22:27
bytesofman updated this revision to Diff 44405.Jan 21 2024, 00:23

prevent render errors in Alias component, number instead of string bug

bytesofman updated this revision to Diff 44406.Jan 21 2024, 00:25

remove debug logging

bytesofman added inline comments.Jan 21 2024, 00:27
cashtab/src/validation/index.js
427 ↗(On Diff #44381)

should be standardized, will fix

the parseInt case is actually the bug, appConfig.dustSats is already an integer

Harbormaster completed remote builds in B26520: Diff 44405.Jan 21 2024, 00:27
Harbormaster completed remote builds in B26521: Diff 44406.
Closed by commit rABCfe9f1f67bf43: [Cashtab] Deprecate all duplicated legacy implementations of toXec and… (authored by bytesofman). · Explain WhyJan 21 2024, 00:30
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCfe9f1f67bf43: [Cashtab] Deprecate all duplicated legacy implementations of toXec and….

Revision Contents
Changeset List

PathSize
cashtab/
src/
components/
Airdrop/
8 lines
Alias/
69 lines
Etokens/
11 lines
Send/
6 lines
utils/
__mocks__/
4 lines
__tests__/
43 lines
38 lines
validation/
__tests__/
31 lines
11 lines

Diff 44405

View Options

cashtab/src/components/Airdrop/Airdrop.js

Loading...
View Options

cashtab/src/components/Alias/Alias.js

Loading...
View Options

cashtab/src/components/Etokens/CreateToken.js

Loading...
View Options

cashtab/src/components/Send/SendXec.js

Loading...
View Options

cashtab/src/utils/__mocks__/sendBCH.js

Loading...
View Options

cashtab/src/utils/__tests__/cashMethods.test.js

Loading...
View Options

cashtab/src/utils/cashMethods.js

Loading...
View Options

cashtab/src/validation/__tests__/index.test.js

Loading...
View Options

cashtab/src/validation/index.js

Loading...