[Cashtab] Remove unused deps
ClosedPublic
Actions

Authored by bytesofman on Jan 23 2024, 15:00.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC1e0b8fa292e8: [Cashtab] Remove unused deps

Summary

Depends on D15246

Remove dependencies no longer used in Cashtab

bc-bip68 - must have been accidentally added while testing lock time
lodash.isempty - was once used with bch-api utxo org methods, should have been deleted when chronik implemented
lodash.isequal - same
long - used when chronik first introduced and numbers were of this type
prompts - probably from original create react app before it was ejected
, lodash.isempty, lodash.isequal, long, tailwindscss, and prompts

Test Plan

npm run build
grep -r --exclude-dir={node_modules,build,coverage} 'bc-bip68' and no output
grep -r --exclude-dir={node_modules,build,coverage} 'lodash.isempty' and no output
grep -r --exclude-dir={node_modules,build,coverage} 'lodash.isequal' and no output
grep -r --exclude-dir={node_modules,build,coverage} 'long' and no output
grep -r --exclude-dir={node_modules,build,coverage} 'prompts' and no output

Diff Detail

Repository

rABC Bitcoin ABC

Branch

deps-refactors-cashtab

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26575
Build 52720: Build Diff	cashtab-tests
Build 52719: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 23 2024, 15:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 23 2024, 15:00

bytesofman published this revision for review.Jan 23 2024, 15:08

Harbormaster completed remote builds in B26575: Diff 44479.Jan 23 2024, 15:08

Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Tail of the build log:

/work/cashtab /work/abc-ci-builds/cashtab-tests
npm WARN deprecated sourcemap-codec@1.4.8: Please use @jridgewell/sourcemap-codec instead
npm WARN deprecated stable@0.1.8: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility
npm WARN deprecated rollup-plugin-terser@7.0.2: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-terser
npm WARN deprecated workbox-cacheable-response@6.6.0: workbox-background-sync@6.6.0
npm WARN deprecated text-encoding@0.6.4: no longer maintained
npm WARN deprecated domexception@4.0.0: Use your platform's native DOMException instead
npm WARN deprecated abab@2.0.6: Use your platform's native atob() and btoa() methods instead
npm WARN deprecated @babel/plugin-proposal-private-methods@7.18.6: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-private-methods instead.
npm WARN deprecated @babel/plugin-proposal-optional-chaining@7.21.0: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-optional-chaining instead.
npm WARN deprecated @babel/plugin-proposal-class-properties@7.18.6: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-class-properties instead.
npm WARN deprecated @babel/plugin-proposal-numeric-separator@7.18.6: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-numeric-separator instead.
npm WARN deprecated @babel/plugin-proposal-nullish-coalescing-operator@7.18.6: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-nullish-coalescing-operator instead.
npm WARN deprecated @babel/plugin-proposal-private-property-in-object@7.21.11: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-private-property-in-object instead.
npm WARN deprecated ts-custom-error@2.2.2: npm package tarball contains useless codeclimate-reporter binary, please update to version 3.1.1. See https://github.com/adriengibrat/ts-custom-error/issues/32

added 1929 packages, and audited 1930 packages in 24s

264 packages are looking for funding
run `npm fund` for details

found 0 vulnerabilities

> cashtab@1.0.0 build
> node scripts/build.js

Creating an optimized production build...
Failed to compile.

Module not found: Error: Can't resolve 'long' in '/work/cashtab/node_modules/chronik-client/dist/proto'

Build cashtab-tests failed with exit code 1

bytesofman added a child revision: D15248: [Cashtab] Move dev dependencies to dev dependencies.Jan 23 2024, 15:10

bytesofman planned changes to this revision.Jan 23 2024, 15:14

rebuild package-lock.json

Harbormaster completed remote builds in B26578: Diff 44482.Jan 23 2024, 15:20

Fabien accepted this revision.Jan 23 2024, 15:36

Fabien added a subscriber: Fabien.

Fabien added inline comments.

cashtab/package-lock.json
35039 ↗	(On Diff #44482)	Weird, so some dependency needed 4.0.0 and we used to have 5.2.x, but somehow it managed to work ?

This revision is now accepted and ready to land.Jan 23 2024, 15:36

bytesofman added inline comments.Jan 23 2024, 17:32

cashtab/package-lock.json
35039 ↗	(On Diff #44482)	`long` is still a dependency of a dependency (`protobufjs`) in `chronik-client`, so it is getting installed + reflected in `package-lock.json` Previously, Cashtab also directly installed `5.2.x` -- which apparently did not conflict with this req (as, weirdly, 4.0.0 was being installed too).
36625 ↗	(On Diff #44482)	we used to have 4.0.0 for chronik-client and 5.2.3 for Cashtab (unused)