Page MenuHomePhabricator
Differential D15271

[ecash-herald] Parse v0 paybutton txs
ClosedPublic
Actions

Authored by bytesofman on Jan 24 2024, 20:29.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCf0543b834adb: [ecash-herald] Parse v0 paybutton txs
Summary

Parse the data element of paybutton txs

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
herald-parse-pb
Lint
Lint Errors
SeverityLocationCodeMessage
Errorapps/ecash-herald/test/mocks/appTxSamples.js:437ESLINTno-useless-escape
Errorapps/ecash-herald/test/mocks/appTxSamples.js:437ESLINTno-useless-escape
Errorapps/ecash-herald/test/mocks/appTxSamples.js:475ESLINTno-useless-escape
Errorapps/ecash-herald/test/mocks/appTxSamples.js:475ESLINTno-useless-escape
Unit
No Test Coverage
Build Status
Buildable 26625
Build 52819: Build Diffecash-herald-tests
Build 52818: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 24 2024, 20:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 24 2024, 20:29
Harbormaster completed remote builds in B26623: Diff 44550.Jan 24 2024, 20:30
bytesofman updated this revision to Diff 44551.Jan 24 2024, 20:35

Add more cases and tests

Harbormaster completed remote builds in B26624: Diff 44551.Jan 24 2024, 20:36
bytesofman published this revision for review.Jan 24 2024, 20:38
bytesofman updated this revision to Diff 44552.Jan 24 2024, 20:39

remove @generated from AppTxSamples, this file should be reviewed as new test cases are added

Harbormaster completed remote builds in B26625: Diff 44552.Jan 24 2024, 20:39
bytesofman updated this revision to Diff 44553.Jan 24 2024, 20:40

lint

Harbormaster completed remote builds in B26626: Diff 44553.Jan 24 2024, 20:42
PiRK accepted this revision.Jan 25 2024, 08:22
This revision is now accepted and ready to land.Jan 25 2024, 08:22
Closed by commit rABCf0543b834adb: [ecash-herald] Parse v0 paybutton txs (authored by bytesofman). · Explain WhyJan 25 2024, 13:35
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCf0543b834adb: [ecash-herald] Parse v0 paybutton txs.

Revision Contents
Changeset List

PathSize
apps/
ecash-herald/
1 line
constants/
1 line
src/
34 lines
test/
mocks/
41 lines
12 lines

Diff 44552

View Options

apps/ecash-herald/config.js

Loading...
View Options

apps/ecash-herald/constants/op_return.js

Loading...
View Options

apps/ecash-herald/src/parse.js

Loading...
View Options

apps/ecash-herald/test/mocks/appTxSamples.js

Loading...
View Options

apps/ecash-herald/test/parse.test.js

Loading...