[validation] Annotate ChainstateManager::m_best_header as guarded by cs_main
ClosedPublic
Actions

Authored by PiRK on Jan 26 2024, 10:14.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC744681778e9f: [validation] Annotate ChainstateManager::m_best_header as guarded by cs_main

Summary

This is a partial backport of core#26140
https://github.com/bitcoin/bitcoin/pull/26140/commits/1d87137227ee125018006935d55164a72265c935
Depends on D15287

Test Plan

With Debug:

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26666
Build 52900: Build Diff	build-clang-tidy · build-without-wallet · build-debug · build-diff · build-clang · lint-circular-dependencies
Build 52899: arc lint + arc unit

Event Timeline

PiRK created this revision.Jan 26 2024, 10:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 26 2024, 10:14

PiRK requested review of this revision.Jan 26 2024, 10:14

teamcity edited the summary of this revision. (Show Details)Jan 26 2024, 10:14

Fabien accepted this revision.Jan 26 2024, 10:16

This revision is now accepted and ready to land.Jan 26 2024, 10:16

PiRK added a child revision: D15289: [net processing] Annotate nUnconnectingHeaders as guarded by g_msgproc_mutex and move to Peer.Jan 26 2024, 10:16

Harbormaster completed remote builds in B26666: Diff 44608.Jan 26 2024, 10:29

Closed by commit rABC744681778e9f: [validation] Annotate ChainstateManager::m_best_header as guarded by cs_main (authored by dergoegge <n.goeggi@gmail.com>, committed by PiRK). · Explain WhyJan 26 2024, 17:17

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC744681778e9f: [validation] Annotate ChainstateManager::m_best_header as guarded by cs_main.

Revision Contents
Changeset List

Path

Size

src/

validation.h

2 lines

Diff 44608

View Options

[validation] Annotate ChainstateManager::m_best_header as guarded by cs_mainClosedPublicActions