Page MenuHomePhabricator

[Cashtab] Deprecate react-device-detect
ClosedPublic

Authored by emack on Jan 31 2024, 03:02.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC0835f3ca5f46: [Cashtab] Deprecate react-device-detect
Summary

This library was previously used for a legacy QR scanning compatibility issue on iOS devices. This is no longer the case (Apple has opened their API) and the existing width < 769 pixels check is enough to define the platform as mobile, hence deprecating this library.

Test Plan

grep -r react-device-detect src/ and no outputs
Load react-device-detect.netlify.app on mobile device
Go to send screen and ensure QR code scanner opens camera
Go to send token screen and ensure QR code scanner opens camera
Go to Setting screen and toggle the Auto-Camera open option

Diff Detail

Repository
rABC Bitcoin ABC
Branch
depReactDeviceDetect
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26784
Build 53136: Build Diffcashtab-tests
Build 53135: arc lint + arc unit

Event Timeline

emack requested review of this revision.Jan 31 2024, 03:02

Refreshed package-lock.json to sync version bump

This revision is now accepted and ready to land.Jan 31 2024, 11:09
This revision was landed with ongoing or failed builds.Jan 31 2024, 11:37
This revision was automatically updated to reflect the committed changes.