Page MenuHomePhabricator
Differential D15341

[Cashtab] Remove async useEffect methods
ClosedPublic
Actions

Authored by bytesofman on Jan 31 2024, 11:52.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC2f1ffc55715f: [Cashtab] Remove async useEffect methods
Summary

React 18 does not support async useEffect blocks. In prep to upgrade to React 18, refactor these blocks so that we are not awaiting withing useEffect

Note: we can still achieve the same functionality. This is a syntax issue.

Test Plan

Confirm new functions contain exact content of old useEffect blocks. npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
no-async-use-effect
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26792
Build 53152: Build Diffcashtab-tests
Build 53151: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 31 2024, 11:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 31 2024, 11:52
bytesofman updated this revision to Diff 44786.Jan 31 2024, 11:52

version bump

bytesofman published this revision for review.Jan 31 2024, 11:54
bytesofman added inline comments.
cashtab/src/components/Configure/Configure.js
571

in this case, there is no need to await within the useEffect, so simply remove async/await

Harbormaster completed remote builds in B26791: Diff 44785.Jan 31 2024, 12:28
Harbormaster completed remote builds in B26792: Diff 44786.
PiRK accepted this revision.Jan 31 2024, 14:54
This revision is now accepted and ready to land.Jan 31 2024, 14:54
Closed by commit rABC2f1ffc55715f: [Cashtab] Remove async useEffect methods (authored by bytesofman). · Explain WhyJan 31 2024, 19:17
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC2f1ffc55715f: [Cashtab] Remove async useEffect methods.

Revision Contents
Changeset List

PathSize
cashtab/
2 lines
src/
components/
Alias/
41 lines
AppModes/
8 lines
Configure/
38 lines
hooks/
16 lines

Diff 44786

View Options

cashtab/package.json

Loading...
View Options

cashtab/src/components/Alias/Alias.js

Loading...
View Options

cashtab/src/components/AppModes/WebApp.js

Loading...
View Options

cashtab/src/components/Configure/Configure.js

Loading...
View Options

cashtab/src/hooks/useWallet.js

Loading...