Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCf676d3619edb: [Chronik] Add `/broadcast-tx(s)` endpoints

Summary

These endpoints are similar to the sendrawtransaction RPC, with some differences:

They take a serialized BroadcastTx(s)Request (similar to most Chronik endpoints)
They perform an SLP/ALP check and reject all txs atomically if any tokens are unintentionally burned

Currently /broadcast-txs, after the token check, simply broadcasts txs one by one and not as a package. This matches the current NNG Chronik behavior, but in the future we could use the AcceptMultipleTransactions function from the node to make that atomic, too.

Depends on D15369.

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chronik-slp-broadcast

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26889
Build 53345: Build Diff	chronik-client-integration-tests · build-without-wallet · build-diff · build-debug · build-clang · build-chronik-plugins · build-clang-tidy · build-chronik
Build 53344: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Feb 2 2024, 00:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 2 2024, 00:42

tobias_ruck requested review of this revision.Feb 2 2024, 00:42

Harbormaster completed remote builds in B26865: Diff 44884.Feb 2 2024, 00:58

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

tobias_ruck added a child revision: D15371: [Chronik] Add `/validate-tx` endpoint.Feb 2 2024, 01:00

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

The tests are failing when you are sending invalid txs. This is the expected behavior but the ChronikClient.send() method always expects success

This revision now requires changes to proceed.Feb 2 2024, 12:58

Fabien mentioned this in D15371: [Chronik] Add `/validate-tx` endpoint.Feb 2 2024, 13:01

in my defense, I was sleeping

fix tests

fix rocksdb features

Harbormaster completed remote builds in B26889: Diff 44920.Feb 2 2024, 15:46

Harbormaster completed remote builds in B26890: Diff 44921.Feb 2 2024, 16:14

add test for /broadcast-txs

tobias_ruck edited the summary of this revision. (Show Details)Feb 3 2024, 12:23

Harbormaster completed remote builds in B26896: Diff 44931.Feb 3 2024, 12:38

tobias_ruck mentioned this in D15386: [Chronik] Add `/token-id/...` endpoints.Feb 5 2024, 19:00

tobias_ruck added a child revision: D15386: [Chronik] Add `/token-id/...` endpoints.Feb 5 2024, 19:00

Fabien requested changes to this revision.Feb 6 2024, 14:50

Fabien added inline comments.

chronik/chronik-indexer/src/query/broadcast.rs
66 ↗	(On Diff #44931)	Can we make the max fee a constant, or use the value from the node if possible ?
94 ↗	(On Diff #44931)	slp is also a bad name here => token
chronik/chronik-indexer/src/query/tx_token_data.rs
181 ↗	(On Diff #44931)

This revision now requires changes to proceed.Feb 6 2024, 14:50

tobias_ruck mentioned this in D15409: [Chronik] Bridge `calc_fee` and `default_max_raw_tx_fee_rate_per_kb` to Rust.Feb 8 2024, 14:54

rebase on D15409 and use ffi methods

fix colored in from_unbroadcast_tx when color_tx returns None

Harbormaster completed remote builds in B27002: Diff 45061.Feb 8 2024, 15:32

Harbormaster completed remote builds in B27004: Diff 45063.Feb 8 2024, 15:50

tobias_ruck mentioned this in rABC716daa44a10b: [Chronik] Bridge `calc_fee` and `default_max_raw_tx_fee_rate_per_kb` to Rust.Feb 9 2024, 11:33

Fabien accepted this revision.Feb 11 2024, 10:08

This revision is now accepted and ready to land.Feb 11 2024, 10:08

Closed by commit rABCf676d3619edb: [Chronik] Add `/broadcast-tx(s)` endpoints (authored by tobias_ruck). · Explain WhyFeb 11 2024, 21:22

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABCf676d3619edb: [Chronik] Add `/broadcast-tx(s)` endpoints.

[Chronik] Add `/broadcast-tx(s)` endpoints
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 44920

Cargo.lock

chronik/chronik-bridge/src/util.rs

chronik/chronik-db/Cargo.toml

chronik/chronik-http/src/server.rs

chronik/chronik-indexer/Cargo.toml

chronik/chronik-indexer/src/indexer.rs

chronik/chronik-indexer/src/query/broadcast.rs

chronik/chronik-indexer/src/query/mod.rs

chronik/chronik-indexer/src/query/tx_token_data.rs

chronik/chronik-proto/proto/chronik.proto

test/functional/chronik_token_alp.py

test/functional/chronik_token_burn.py

test/functional/chronik_token_parse_failure.py

test/functional/chronik_token_script_group.py

test/functional/chronik_token_slp_fungible.py

test/functional/chronik_token_slp_mint_vault.py

test/functional/chronik_token_slp_nft1.py

test/functional/test_framework/chronik/client.py

test/functional/test_framework/chronik/token_tx.py

[Chronik] Add `/broadcast-tx(s)` endpointsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 44920

Cargo.lock

chronik/chronik-bridge/src/util.rs

chronik/chronik-db/Cargo.toml

chronik/chronik-http/src/server.rs

chronik/chronik-indexer/Cargo.toml

chronik/chronik-indexer/src/indexer.rs

chronik/chronik-indexer/src/query/broadcast.rs

chronik/chronik-indexer/src/query/mod.rs

chronik/chronik-indexer/src/query/tx_token_data.rs

chronik/chronik-proto/proto/chronik.proto

test/functional/chronik_token_alp.py

test/functional/chronik_token_burn.py

test/functional/chronik_token_parse_failure.py

test/functional/chronik_token_script_group.py

test/functional/chronik_token_slp_fungible.py

test/functional/chronik_token_slp_mint_vault.py

test/functional/chronik_token_slp_nft1.py

test/functional/test_framework/chronik/client.py

test/functional/test_framework/chronik/token_tx.py

[Chronik] Add `/broadcast-tx(s)` endpoints
ClosedPublic
Actions

Revision Contents
Changeset List