Page MenuHomePhabricator
Differential D15367

[Cashtab] Specify latest stable version of nodejs
ClosedPublic
Actions

Authored by bytesofman on Feb 1 2024, 23:31.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC3822a7078b93: [Cashtab] Specify latest stable version of nodejs
Summary

Node 16 is well past end of life. Specify latest stable version of node in Cashtab nvmrc file. Update CONTRIBUTING.md

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cashtab-nvmrc
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26892
Build 53351: Build Diffcashtab-tests
Build 53350: arc lint + arc unit

Event Timeline

bytesofman created this revision.Feb 1 2024, 23:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 1 2024, 23:31
bytesofman updated this revision to Diff 44879.Feb 1 2024, 23:36

back out prettier changes

Harbormaster completed remote builds in B26859: Diff 44878.Feb 1 2024, 23:37
bytesofman updated this revision to Diff 44880.Feb 1 2024, 23:38

newlines, comments

Harbormaster completed remote builds in B26860: Diff 44879.Feb 1 2024, 23:40
Harbormaster completed remote builds in B26861: Diff 44880.
bytesofman mentioned this in D15368: [monorepo] Add CONTRIBUTING.md to .prettierignore.Feb 1 2024, 23:41
bytesofman published this revision for review.Feb 1 2024, 23:42
bytesofman added inline comments.
.prettierignore
26 ↗(On Diff #44880)

D15368

PiRK requested changes to this revision.Feb 2 2024, 07:53
PiRK added a subscriber: PiRK.
PiRK added inline comments.
CONTRIBUTING.md
205 ↗(On Diff #44880)
This revision now requires changes to proceed.Feb 2 2024, 07:53
bytesofman mentioned this in rABCf55d8be8857b: [monorepo] Add CONTRIBUTING.md to .prettierignore.Feb 2 2024, 13:11
bytesofman updated this revision to Diff 44908.Feb 2 2024, 13:13
bytesofman marked an inline comment as done.

capitalization error fix

PiRK accepted this revision.Feb 2 2024, 13:15
This revision is now accepted and ready to land.Feb 2 2024, 13:15
Harbormaster completed remote builds in B26878: Diff 44908.Feb 2 2024, 13:18
bytesofman planned changes to this revision.Feb 2 2024, 13:42

hm while this does work locally, I should also update the Docker deployment in this diff. In testing, this isn't working out since other deps need to be updated.

bytesofman updated this revision to Diff 44910.Feb 2 2024, 13:42

change dockerfile to match nvm use

This revision is now accepted and ready to land.Feb 2 2024, 13:42
bytesofman planned changes to this revision.Feb 2 2024, 13:42
Harbormaster completed remote builds in B26880: Diff 44910.Feb 2 2024, 13:51
bytesofman updated this revision to Diff 44923.Feb 2 2024, 17:42

Update Dockerfile

This revision is now accepted and ready to land.Feb 2 2024, 17:42
Harbormaster completed remote builds in B26892: Diff 44923.Feb 2 2024, 17:49
bytesofman planned changes to this revision.Feb 2 2024, 17:49

npm ci is taking a very long time with this, need to find out why

bytesofman updated this revision to Diff 44965.Feb 5 2024, 13:45

rebase, version bump

This revision is now accepted and ready to land.Feb 5 2024, 13:45
This revision was landed with ongoing or failed builds.Feb 5 2024, 13:48
Closed by commit rABC3822a7078b93: [Cashtab] Specify latest stable version of nodejs (authored by bytesofman). · Explain Why
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC3822a7078b93: [Cashtab] Specify latest stable version of nodejs.
Harbormaster completed remote builds in B26926: Diff 44965.Feb 5 2024, 14:11

Revision Contents
Changeset List

PathSize
10 lines
cashtab/
2 lines
2 lines
2 lines

Diff 44923

View Options

CONTRIBUTING.md

Loading...
View Options

cashtab/.nvmrc

Loading...
View Options

cashtab/Dockerfile

Loading...
View Options

cashtab/package.json

Loading...