Page MenuHomePhabricator

[Cashtab] Specify latest stable version of nodejs
ClosedPublic

Authored by bytesofman on Feb 1 2024, 23:31.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC3822a7078b93: [Cashtab] Specify latest stable version of nodejs
Summary

Node 16 is well past end of life. Specify latest stable version of node in Cashtab nvmrc file. Update CONTRIBUTING.md

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cashtab-nvmrc
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26892
Build 53351: Build Diffcashtab-tests
Build 53350: arc lint + arc unit

Event Timeline

bytesofman published this revision for review.Feb 1 2024, 23:42
bytesofman added inline comments.
.prettierignore
26 ↗(On Diff #44880)
PiRK requested changes to this revision.Feb 2 2024, 07:53
PiRK added a subscriber: PiRK.
PiRK added inline comments.
CONTRIBUTING.md
205 ↗(On Diff #44880)
This revision now requires changes to proceed.Feb 2 2024, 07:53
bytesofman marked an inline comment as done.

capitalization error fix

This revision is now accepted and ready to land.Feb 2 2024, 13:15

hm while this does work locally, I should also update the Docker deployment in this diff. In testing, this isn't working out since other deps need to be updated.

change dockerfile to match nvm use

This revision is now accepted and ready to land.Feb 2 2024, 13:42
This revision is now accepted and ready to land.Feb 2 2024, 17:42

npm ci is taking a very long time with this, need to find out why

This revision is now accepted and ready to land.Feb 5 2024, 13:45
This revision was landed with ongoing or failed builds.Feb 5 2024, 13:48
This revision was automatically updated to reflect the committed changes.